Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Loadout Items Wave 1 #425

Merged
merged 84 commits into from
Jul 5, 2024

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented May 30, 2024

Description

The original release of Loadouts to EE did not have much in the way of actual implementation as far as the item list was concerned. This PR seeks to get a head start at fixing that by implementing a fairly sizeable chunk of new items that can be bought with loadout points.

One important addition is the use of "non-clothing-job-related items", which helps further set this version of Loadouts apart from the /tg/ style of loadouts implemented elsewhere. One of the key strengths of this loadout system is that it's not limited to just replacing a job's clothing selections, but can also add items unrelated to clothing. My given example for this is the new option for Security characters(provided they have sufficient number of hours as a Security Officer) can spend roughly half their loadout points to start with a spare magazine for their handgun.

Secondly, we also now have an opportunity to place non-nanotrasen corporate items in the game, in such a way that players can tie their characters to other corporations. Ostensibly this is to build up to the idea of "Contractor" characters. I hope that this will help broaden people's horizons.

On "Syndie" items

I'd like to take this as an opportunity to kind of push people away from the whole thing of "THATS A SYNDICATE ITEM!!!!" wherever possible. For the most part this is very much NRP behavior that I'd like to discourage. With some notable exceptions, this doesn't mean outright antag items should be obtainable through Loadouts. To that end, items such as Interdyne branded smokes, Cybersun branded clothing, and other items with "In-Universe Company Brands" should be moved away from their identity as strictly antag objects, and instead things characters could reasonably have bought with their paycheck.

Technical Changes

I had to make some improvements to the way Loadouts handles species, namely it wasn't previously possible to have an item require any entry from a list of species. I updated it so that SpeciesRequirement takes a list of Species, and will accept any entry from that list. My given example for this is the entries for Nitrogen air tanks, which can only be purchased in loadouts by SlimePersons and Vox(who are not currently playable, but I am accounting for them). Other usage of this is in the Oni-specific Security items. I do hope to use this as an opportunity to introduce more species-specific goods in the future.

Media

Outerwear
image

More job-related selections available to some departments
image

More variety of trinkets and items, including instruments!
image

Species Specific Items!
image

Changelog

🆑 VMSolidus

  • add: The catalog of items available via Loadouts has been greatly expanded. Have fun customizing your characters!

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels May 30, 2024
@VMSolidus
Copy link
Member Author

By intentional design, the Slime nitrogen tanks are 1 point cheaper than oxygen tanks. They are discounted by the cost a human would have had to pay to start with a spare emergency oxygen tank. This is meant to reimburse them for the obnoxious fact that they start with an emergency oxygen tank in their survival box.

@DangerRevolution DangerRevolution enabled auto-merge (squash) May 31, 2024 10:04
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 2, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Jun 3, 2024
@VMSolidus
Copy link
Member Author

image

I have significantly increased the number of existing categories, as well as moved things around, and added more items to fit said categories. I think for a lot of things, any items listed as "exclusive: true" should probably be discounted if they're a job related item that is replacing something you already start with. Such as for example, the option for Security to start with security webbing instead of a belt(I had to add a FILLED webbing just for this purpose).

Also fun fact, the "Insulated gloves" that are for assistant only, are actually budget insuls. By popular request, assistants can now gamble loadout points on killing themselves with the budget roulette.

@VMSolidus
Copy link
Member Author

I've added the Sol Common Translator to loadouts, as a somewhat cheap entry for the items tab. This will serve as a way of simply introducing to players that the translator items exist, and gives an easy tie-in with Languages and Loadouts.
image

@github-actions github-actions bot removed Status: Merge Conflict FIX YOUR PR AAAGH Changes: C# Changes any cs files labels Jun 21, 2024
auto-merge was automatically disabled June 28, 2024 18:16

Pull Request is not mergeable

@github-actions github-actions bot added Status: Needs Review Someone please review this labels Jun 29, 2024
@VMSolidus
Copy link
Member Author

How the hell has this not already been merged?

@DEATHB4DEFEAT
Copy link
Member

uhhhhhhhhhhhhhhhhh

Resources/Prototypes/Loadouts/Jobs/engineering.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Loadouts/categories.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Loadouts/uniform.yml Outdated Show resolved Hide resolved
@VMSolidus
Copy link
Member Author

@DEATHB4DEFEAT Done.

@Peptide90 Peptide90 merged commit 8de45e7 into Simple-Station:master Jul 5, 2024
12 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants