Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random Announcer Fixes #557

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Random Announcer Fixes #557

merged 5 commits into from
Jul 26, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Jul 17, 2024 •
edited
Loading

Description

In theory the test works, too tired to want to figure it out right now.

TODO

  • XMLDocs instead of random comments
  • Announcer audio test
    • Fix the resource error
  • Remove random extra announcement files
  • Fix test errors
  • Add alert announcements to every announcer

Changelog

🆑

  • fix: Fixed some NEIL announcements not playing audio

@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something labels Jul 17, 2024
@github-actions github-actions bot added Changes: Audio Changes any ogg files Changes: C# Changes any cs files labels Jul 17, 2024
@SimpleStation14 SimpleStation14 changed the title random announcer fixes Random Announcer Fixes Jul 17, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT mentioned this pull request Jul 17, 2024
Closed
@DEATHB4DEFEAT
Copy link
Member Author

image

@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review July 18, 2024 01:22
VMSolidus
VMSolidus approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das a lot of file deletions lol.
But we DID pull the same audio library twice lmao.

@OldDanceJacket OldDanceJacket merged commit 7d1b23f into Simple-Station:master Jul 26, 2024
12 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 26, 2024
@SimpleStation14
Automatic Changelog Update (#557)
634e933
@Darkmajia Darkmajia mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@OldDanceJacket OldDanceJacket OldDanceJacket approved these changes

@DangerRevolution DangerRevolution DangerRevolution left review comments

Assignees
No one assigned
Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DEATHB4DEFEAT @VMSolidus @OldDanceJacket @DangerRevolution