Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dionas Slow And Steady #704

Merged

Conversation

angelofallars
Copy link
Contributor

@angelofallars angelofallars commented Aug 8, 2024

Description

Dionas now have 25% slower movement speed in exchange for total slip immunity and slow immunity (except lying down).

Note that this also prevents slowdowns from hunger and thirst.

This also fixes an existing bug with Sluggish and Snail-Paced related to TraitSpeedModifierSystem, as it was not applying the reduced movement speed upon spawning, only when the movement speed has been modified by another source. TraitSpeedModifierSystem has been moved from Content.Server to Content.Shared.

This used to be a trait costing 3 points, but is now given for free to all Dionas per request of @VMSolidus.

Media

Expand

Speed with no items

image

Speed wearing a jugsuit, wearing a duffel bag, holding one duffel bag in each arm, and walking through a puddle of glue covered in spider webs.

image

Changelog

🆑 Skubman

  • add: Dionas have been given a 25% slower movement speed. In exchange for that, they gain absolute slip immunity and movement speed modifier immunity. This makes them immune to slowdown from things like duffelbags, hardsuits, and spider webs.
  • fix: Sluggish and Snail-Paced will now properly apply their movement penalties upon joining.

Also fixes a bug with Sluggish and Snail-Paced not applying
their speed modifiers until an entity gets their movement
speed adjusted.
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Aug 8, 2024
@github-actions github-actions bot removed the Changes: Localization Changes any ftl files label Aug 8, 2024
@angelofallars angelofallars changed the title New Trait: Slow And Steady Make Dionas Slow And Steady Aug 8, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 9, 2024
@DangerRevolution DangerRevolution requested a review from a team August 9, 2024 10:54
@DangerRevolution DangerRevolution added Size: 4-Small For small issues/PRs Priority: 3-Medium Needs to be resolved at some point Type: Feature Creation of or significant changes to a feature labels Aug 9, 2024
@VMSolidus VMSolidus merged commit f4d2e35 into Simple-Station:master Aug 9, 2024
13 checks passed
SimpleStation14 added a commit that referenced this pull request Aug 9, 2024
tmcqueen pushed a commit to tmcqueen/Syndicate-Station that referenced this pull request Aug 24, 2024
# Description

Dionas now have 25% slower movement speed in exchange for total slip
immunity and slow immunity (except lying down).

Note that this also prevents slowdowns from hunger and thirst.

This also fixes an existing bug with Sluggish and Snail-Paced related to
`TraitSpeedModifierSystem`, as it was not applying the reduced movement
speed upon spawning, only when the movement speed has been modified by
another source. `TraitSpeedModifierSystem` has been moved from
`Content.Server` to `Content.Shared`.

This used to be a trait costing 3 points, but is now given for free to
all Dionas per request of @VMSolidus.

## Media

<details><summary>Expand</summary>

**Speed with no items**


![image](https://github.com/user-attachments/assets/b723614a-79fe-401c-ae53-2ad98ff9a6d3)

**Speed wearing a jugsuit, wearing a duffel bag, holding one duffel bag
in each arm, and walking through a puddle of glue covered in spider
webs.**


![image](https://github.com/user-attachments/assets/a934d2c1-437f-463c-8fe3-63b7b54a1f58)

</details>

# Changelog

:cl: Skubman
- add: Dionas have been given a 25% slower movement speed. In exchange
for that, they gain absolute slip immunity and movement speed modifier
immunity. This makes them immune to slowdown from things like
duffelbags, hardsuits, and spider webs.
- fix: Sluggish and Snail-Paced will now properly apply their movement
penalties upon joining.
tmcqueen pushed a commit to tmcqueen/Syndicate-Station that referenced this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants