-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Dionas Slow And Steady #704
Merged
VMSolidus
merged 4 commits into
Simple-Station:master
from
angelofallars:add-trait-slow-and-steady
Aug 9, 2024
Merged
Make Dionas Slow And Steady #704
VMSolidus
merged 4 commits into
Simple-Station:master
from
angelofallars:add-trait-slow-and-steady
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a bug with Sluggish and Snail-Paced not applying their speed modifiers until an entity gets their movement speed adjusted.
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
labels
Aug 8, 2024
VMSolidus
previously requested changes
Aug 9, 2024
Content.Shared/Traits/Assorted/Components/SlipImmunityComponent.cs
Outdated
Show resolved
Hide resolved
DangerRevolution
approved these changes
Aug 9, 2024
DangerRevolution
added
Size: 4-Small
For small issues/PRs
Priority: 3-Medium
Needs to be resolved at some point
Type: Feature
Creation of or significant changes to a feature
labels
Aug 9, 2024
Peptide90
approved these changes
Aug 9, 2024
VMSolidus
approved these changes
Aug 9, 2024
SimpleStation14
added a commit
that referenced
this pull request
Aug 9, 2024
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
# Description Dionas now have 25% slower movement speed in exchange for total slip immunity and slow immunity (except lying down). Note that this also prevents slowdowns from hunger and thirst. This also fixes an existing bug with Sluggish and Snail-Paced related to `TraitSpeedModifierSystem`, as it was not applying the reduced movement speed upon spawning, only when the movement speed has been modified by another source. `TraitSpeedModifierSystem` has been moved from `Content.Server` to `Content.Shared`. This used to be a trait costing 3 points, but is now given for free to all Dionas per request of @VMSolidus. ## Media <details><summary>Expand</summary> **Speed with no items** ![image](https://github.com/user-attachments/assets/b723614a-79fe-401c-ae53-2ad98ff9a6d3) **Speed wearing a jugsuit, wearing a duffel bag, holding one duffel bag in each arm, and walking through a puddle of glue covered in spider webs.** ![image](https://github.com/user-attachments/assets/a934d2c1-437f-463c-8fe3-63b7b54a1f58) </details> # Changelog :cl: Skubman - add: Dionas have been given a 25% slower movement speed. In exchange for that, they gain absolute slip immunity and movement speed modifier immunity. This makes them immune to slowdown from things like duffelbags, hardsuits, and spider webs. - fix: Sluggish and Snail-Paced will now properly apply their movement penalties upon joining.
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
Priority: 3-Medium
Needs to be resolved at some point
Size: 4-Small
For small issues/PRs
Status: Needs Review
Someone please review this
Type: Feature
Creation of or significant changes to a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dionas now have 25% slower movement speed in exchange for total slip immunity and slow immunity (except lying down).
Note that this also prevents slowdowns from hunger and thirst.
This also fixes an existing bug with Sluggish and Snail-Paced related to
TraitSpeedModifierSystem
, as it was not applying the reduced movement speed upon spawning, only when the movement speed has been modified by another source.TraitSpeedModifierSystem
has been moved fromContent.Server
toContent.Shared
.This used to be a trait costing 3 points, but is now given for free to all Dionas per request of @VMSolidus.
Media
Expand
Speed with no items
Speed wearing a jugsuit, wearing a duffel bag, holding one duffel bag in each arm, and walking through a puddle of glue covered in spider webs.
Changelog
🆑 Skubman