Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs] [templates/nextjs-sxa]: The condition DISBLE_SSG_FETCH has been fixed #SXA-7753 #2007

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Jan 16, 2025

Description / Motivation

The issue was that the DISABLE_FETCH_SSG variable was of type string, not boolean. The conditions have been fixed.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi changed the title [templates/nextjs, templates/nextjs-sxa]: The condition DISBLE_SSG_FETCH has been fixed #SXA-7753 [templates/nextjs] [templates/nextjs-sxa]: The condition DISBLE_SSG_FETCH has been fixed #SXA-7753 Jan 16, 2025
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/SXA-7753-disable-fetch-ssg branch from 7612fcb to 9246064 Compare January 16, 2025 16:23
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@yavorsk yavorsk merged commit dee0924 into dev Jan 17, 2025
1 check passed
@yavorsk yavorsk deleted the bugfix/SXA-7753-disable-fetch-ssg branch January 17, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants