Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs] [templates/nextjs-sxa]: The condition DISBLE_SSG_FETCH has been fixed #SXA-7753 #2007

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[templates/nextjs] [templates/nextjs-sxa]: The condition DISBLE_SSG_FETCH has been fixed #SXA-7753 #2007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
253e9ea
[templates/nextjs, templates/nextjs-sxa]: The condition DISBLE_SSG_F…
Jan 16, 2025
9246064
CHANGELOG has been changed
Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Our versioning strategy is as follows:
* `[templates/nextjs-sxa]` Fixed font-awesome import issue in custom workspace configuration ([#1998](https://github.com/Sitecore/jss/pull/1998))
* `[sitecore-jss-nextjs]` Fixed handling of ? inside square brackets [] in regex patterns to prevent incorrect escaping ([#1999](https://github.com/Sitecore/jss/pull/1999))
* `[sitecore-jss-nextjs]` Improve performance for redirect middleware ([#2003](https://github.com/Sitecore/jss/pull/2003))
* `[templates/nextjs]` `[templates/nextjs-sxa]` Fixed condition of DISABLE_FETCH_SSG ([#2007](https://github.com/Sitecore/jss/pull/2007))

### 🛠 Breaking Change

Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/404.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const getStaticProps: GetStaticProps = async (context) => {
});
let resultErrorPages: ErrorPages | null = null;

if (!process.env.DISABLE_SSG_FETCH) {
if (process.env.DISABLE_SSG_FETCH?.toLowerCase() !== 'true') {
try {
resultErrorPages = await errorPagesService.fetchErrorPages();
} catch (error) {
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/500.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const getStaticProps: GetStaticProps = async (context) => {
});
let resultErrorPages: ErrorPages | null = null;

if (!process.env.DISABLE_SSG_FETCH) {
if (process.env.DISABLE_SSG_FETCH?.toLowerCase() !== 'true') {
try {
resultErrorPages = await errorPagesService.fetchErrorPages();
} catch (error) {
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sitecore-jss/src/templates/nextjs/src/pages/[[...path]].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const getStaticPaths: GetStaticPaths = async (context) => {
let paths: StaticPath[] = [];
let fallback: boolean | 'blocking' = 'blocking';

if (process.env.NODE_ENV !== 'development' && !process.env.DISABLE_SSG_FETCH) {
if (process.env.NODE_ENV !== 'development' && process.env.DISABLE_SSG_FETCH?.toLowerCase() !== 'true') {
try {
// Note: Next.js runs export in production mode
paths = await sitemapFetcher.fetch(context);
Expand Down