Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing in name computation #1566

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Fix spacing in name computation #1566

merged 12 commits into from
Feb 5, 2024

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Feb 5, 2024 •
edited
Loading

Spaces were too eagerly trimmed when computing name from descendants, resulting in them disappearing from the concatenation when they should still be here.

Also split the huge name.ts into its Source and State components. The actual changes are in adding the spaceBefore and spaceAfter properties, and handling them in the various Name.from* functions.

Resolves #1203, resolves #1054.

@Jym77 Jym77 changed the title Name computation fix Fix spacing in name computation Feb 5, 2024
@Jym77 Jym77 self-assigned this Feb 5, 2024
@Jym77 Jym77 added the patch Backwards-compatible change that doesn't touch public API label Feb 5, 2024
@Jym77 Jym77 marked this pull request as ready for review February 5, 2024 15:05
@Jym77 Jym77 requested a review from a team as a code owner February 5, 2024 15:05
@Jym77 Jym77 added major Backwards-incompatible change that touches public API and removed patch Backwards-compatible change that doesn't touch public API labels Feb 5, 2024
rcj-siteimprove
rcj-siteimprove approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌🏼

@Jym77 Jym77 added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit b00efc2 Feb 5, 2024
6 checks passed
@Jym77 Jym77 deleted the name-computation-fix branch February 5, 2024 15:18
@Jym77 Jym77 mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
⚙️ Alfa Development
Archived in project
Milestone
No milestone
2 participants
@Jym77 @rcj-siteimprove