Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in name computation #1566

Merged
merged 12 commits into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/afraid-beers-share.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@siteimprove/alfa-aria": patch
---

**Fixed:** Alfa now correctly handle spaces in accessible names.

* `<br>` elements add a space to the name.
* Text nodes with leading or trailing spaces (including space only nodes) keep the space when concatenated.
* Names of descendants with an `aria-label` are spaced, following browsers' behavior.
5 changes: 5 additions & 0 deletions .changeset/thick-hornets-accept.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@siteimprove/alfa-aria": minor
---

**Breaking:** `Name.Source` and `Name.State` are now exported from the top-level of the package.
5 changes: 5 additions & 0 deletions .changeset/wicked-trains-scream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@siteimprove/alfa-dom": patch
---

**Fixed:** `Node.toString()` now stops dropping text nodes with only spaces.
Loading