Dynamic function calling. #6713

Moderocky · 2024-05-19T21:23:45Z

Additions

New types

executable
function

Obtain function references by name (& source)

[the|a] function [named] %string% [local:(in|from) %script%]
[the] functions [named] %strings% [local:(in|from) %script%]
[all] [the] functions (in|from) %script%

Run function references & get results

# effect
(run|execute) %executable% [with [arg[ument]s]] %-objects%]
# expression for return value
[the] result of %executable% [with [arg[ument]s]] %-objects%]

Little examples

set {_function} to the function named "myFunc"
run {_function} with arguments "hello", "there"
set {_thing} to the result of {_function} with arguments "hello", "there"

Infrastructure

Road-map of future plans

I'm setting down a bit of API here for future Skript features/addons to use,
especially ones that want to run tasks.

I have a few ideas about what I would like to do with this, but nothing finalised yet.

Target Minecraft Versions: any
Requirements: none
Related Issues: fixes #1265, fixes #5838, requires #6702

Co-authored-by: Patrick Miller <[email protected]>

Fusezion · 2024-05-19T21:28:21Z

What about #6254?

Pikachu920 · 2024-05-19T21:47:57Z

also see #6254 (comment). i have to be honest - i'm not really a fan of reflective capabilities in vanilla skript

sovdeeth · 2024-05-19T23:20:38Z

I, too, am not a big fan.
Will update this message with links to my previously expressed opinions on this tomorrow.

Asleeepp · 2024-05-19T23:27:11Z

Sorry if im blanking right now, but why would you even need this in the first place? you could just... run the function? i dont see any point for this atleast in my eyes

APickledWalrus

Are you able to update this since the main PR was merged? Feel free to re-request after

APickledWalrus

I love the concept. Mainly some formatting suggestions/minor syntax corrections.

A few general ideas:

I think it would be good if we could find a way to avoid the specific checks within syntax for DynamicFunctionReference. I also understand if that cannot be reasonably moved though. Can also be done in a future PR

src/main/java/ch/njol/skript/effects/EffRun.java

src/main/java/ch/njol/skript/expressions/ExprFunction.java

src/main/java/ch/njol/skript/lang/function/DynamicFunctionReference.java

Co-authored-by: Patrick Miller <[email protected]>

Moderocky · 2024-12-18T05:57:38Z

src/main/java/ch/njol/skript/expressions/ExprName.java

+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+
 @Name("Name / Display Name / Tab List Name")


Just a note that this is going to need changing if Any X gets merged first.

src/main/java/ch/njol/skript/classes/data/SkriptClasses.java

Efnilite · 2024-12-19T22:44:07Z

src/main/java/ch/njol/skript/classes/data/SkriptClasses.java

+			.examples("run {_function} with arguments 1 and true",
+					"set {_result} to the result of {_function}")
+			.since("INSERT VERSION")
+			.parser(new Parser<DynamicFunctionReference<?>>() {


can this be a named inner class

I'm not sure what you mean by this.

Like private static class DynamicFunctionReferenceParser extends Parser.... I did this in the JavaClasses rework to make the registration section easier to navigate, however its not that big of a deal as most parsers are just an anonymous class

I see. I'm not sure this would add a huge amount of value, since it would just be moved to another place, not made any smaller.

src/main/java/ch/njol/skript/effects/EffRun.java

src/main/java/ch/njol/skript/expressions/ExprResult.java

Efnilite · 2024-12-19T22:47:34Z

src/main/java/ch/njol/skript/expressions/ExprResult.java

+
+	@Override
+	public String toString(@Nullable Event event, final boolean debug) {
+		String text = "the result" + (isPlural ? "s" : "") + " of " + getExpr().toString(event, debug);


SyntaxStringBuilder

In its current state I don't think SyntaxStringBuilder has any use apart from getting to skip the toString bits, since you can't chain append calls.

It's also not useful with propertyexpressions right now because of the annotation mismatch.

Right now, it's just significantly more mess than doing it normally.

Once these shortcomings have been improved I might consider using it.

Most of those issues have been fixed, so you should be fine to use it now. Rather than chaining (although now supported), you can just pass multiple arguments:

builder.append("with arguments", arguments);

APickledWalrus

A few final things

src/main/java/ch/njol/skript/classes/data/SkriptClasses.java

src/main/java/ch/njol/skript/expressions/ExprFunction.java

src/main/java/ch/njol/skript/expressions/ExprResult.java

src/main/java/ch/njol/skript/expressions/ExprFunction.java

APickledWalrus

Looks good

APickledWalrus · 2024-12-29T21:50:57Z

src/main/java/ch/njol/skript/expressions/ExprResult.java

+
+	@Override
+	public String toString(@Nullable Event event, final boolean debug) {
+		String text = "the result" + (isPlural ? "s" : "") + " of " + getExpr().toString(event, debug);


Most of those issues have been fixed, so you should be fine to use it now. Rather than chaining (although now supported), you can just pass multiple arguments:

builder.append("with arguments", arguments);

src/main/java/ch/njol/skript/expressions/ExprResult.java

* Create Script type. * Support script string/name conversion. * Script expression. * Add script lang entry. * Tests for script expression & names. * Support all scripts expression. * Script effects & tests. * Create dummy Script handle for disabled scripts. * Script reflection feature flag. * Restrict literal parsing to commands & parse. * Test feature flag for resolving name. * Split ExprScripts by feature to support disabled scripts. * Fix ExprName tests for new & old behaviour. * Add tests for disabled script handles. * Apply suggestions from code review Co-authored-by: Patrick Miller <[email protected]> * Improve script loading/unloading safety. * Add feature check for script hotswapping. * Use expression stream. * Conformity for file names and proper loading safety. * Document validity & add condition support. * Add script is loaded condition + tests. * Dynamic function calling + tests. * Add language entry for types. * Single-encounter input bootstrapping. * Apply suggestions from code review Co-authored-by: sovdee <[email protected]> * Fix inspection. * Update src/main/java/ch/njol/skript/expressions/ExprFunction.java Co-authored-by: sovdee <[email protected]> * Update src/main/java/ch/njol/skript/expressions/ExprResult.java Co-authored-by: sovdee <[email protected]> * Changes from review. * Fix merge problems. * Remove script command method usage. * Fix branch muck. * Fix more branch muck. * Fix up ExprName. * Add docs. * Add docs. * Add docs. * Fix bits. * Apply suggestions from code review Co-authored-by: Patrick Miller <[email protected]> * Fix some bits. * Function parsing by name. * Fix up some bits for Walrus. * Fix merge error. --------- Co-authored-by: Patrick Miller <[email protected]> Co-authored-by: sovdee <[email protected]>

Moderocky and others added 22 commits May 18, 2024 10:24

Create Script type.

106c555

Support script string/name conversion.

fe9a1fb

Script expression.

da4d4b1

Add script lang entry.

ef742cc

Tests for script expression & names.

571d302

Support all scripts expression.

5da3884

Script effects & tests.

deb484c

Create dummy Script handle for disabled scripts.

f1c0c72

Script reflection feature flag.

6c5a55a

Restrict literal parsing to commands & parse.

e0debc8

Test feature flag for resolving name.

5a692e3

Split ExprScripts by feature to support disabled scripts.

e9c7b74

Fix ExprName tests for new & old behaviour.

1b54e08

Add tests for disabled script handles.

064f1ce

Apply suggestions from code review

c46a5c9

Co-authored-by: Patrick Miller <[email protected]>

Improve script loading/unloading safety.

1c95947

Add feature check for script hotswapping.

43b245d

Use expression stream.

c102949

Conformity for file names and proper loading safety.

40e92b1

Document validity & add condition support.

803b34c

Add script is loaded condition + tests.

3ec719c

Dynamic function calling + tests.

a82c3cd

Moderocky requested review from sovdeeth, APickledWalrus and UnderscoreTud May 19, 2024 21:23

Moderocky added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label May 19, 2024

Efnilite mentioned this pull request Nov 21, 2024

Config navigation syntax. #6719

Merged

APickledWalrus requested changes Nov 22, 2024

View reviewed changes

Merge branch 'feature/script-reflection' into dynamic-function-calling

9772529

Moderocky requested a review from APickledWalrus November 23, 2024 07:55

Moderocky added 5 commits November 23, 2024 08:07

Fix up ExprName.

757ab53

Add docs.

820c9c6

Add docs.

4ce50d6

Add docs.

fb240c5

Fix bits.

36a9afd

Moderocky requested a review from Efnilite November 23, 2024 08:20

sovdeeth approved these changes Dec 8, 2024

View reviewed changes

APickledWalrus requested changes Dec 17, 2024

View reviewed changes

Apply suggestions from code review

3e4d05c

Co-authored-by: Patrick Miller <[email protected]>

Moderocky commented Dec 18, 2024

View reviewed changes

Moderocky added 2 commits December 18, 2024 07:08

Fix some bits.

bd0845a

Function parsing by name.

52a35fc

Moderocky requested a review from APickledWalrus December 18, 2024 06:20

Moderocky added the 2.10 Targeting a 2.10.X version release label Dec 18, 2024

Efnilite requested changes Dec 19, 2024

View reviewed changes

APickledWalrus requested changes Dec 20, 2024

View reviewed changes

Fix up some bits for Walrus.

ba4af38

Moderocky requested review from APickledWalrus and Efnilite December 22, 2024 10:27

Moderocky added 2 commits December 22, 2024 10:33

Merge branch 'feature/script-reflection' into dynamic-function-calling

e1ba77a

Fix merge error.

c1802b5

APickledWalrus approved these changes Dec 29, 2024

View reviewed changes

Moderocky merged commit 1221314 into SkriptLang:feature/script-reflection Dec 29, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic function calling. #6713

Dynamic function calling. #6713

Moderocky commented May 19, 2024 •

edited

Loading

Fusezion commented May 19, 2024

Pikachu920 commented May 19, 2024

sovdeeth commented May 19, 2024

Asleeepp commented May 19, 2024

APickledWalrus left a comment

APickledWalrus left a comment

Moderocky Dec 18, 2024

Efnilite Dec 19, 2024

Moderocky Dec 22, 2024

Efnilite Dec 22, 2024

Moderocky Dec 22, 2024

Efnilite Dec 19, 2024

Moderocky Dec 22, 2024

APickledWalrus Dec 29, 2024

APickledWalrus left a comment

APickledWalrus left a comment

APickledWalrus Dec 29, 2024

Dynamic function calling. #6713

Dynamic function calling. #6713

Conversation

Moderocky commented May 19, 2024 • edited Loading

Additions

Infrastructure

Fusezion commented May 19, 2024

Pikachu920 commented May 19, 2024

sovdeeth commented May 19, 2024

Asleeepp commented May 19, 2024

APickledWalrus left a comment

Choose a reason for hiding this comment

APickledWalrus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

APickledWalrus left a comment

Choose a reason for hiding this comment

APickledWalrus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Moderocky commented May 19, 2024 •

edited

Loading