Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic function calling. #6713
Dynamic function calling. #6713
Changes from 41 commits
106c555
fe9a1fb
da4d4b1
ef742cc
571d302
5da3884
deb484c
f1c0c72
6c5a55a
e0debc8
5a692e3
e9c7b74
1b54e08
064f1ce
c46a5c9
1c95947
43b245d
c102949
40e92b1
803b34c
3ec719c
a82c3cd
e35f9d2
c19648d
1eddf56
ab861c9
19a99d2
97f0356
ab096cc
ca3d648
d543809
58dd1b4
9e81543
5bf9856
0143f2b
9772529
757ab53
820c9c6
4ce50d6
fb240c5
36a9afd
3e4d05c
bd0845a
52a35fc
ba4af38
e1ba77a
c1802b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not great. can we find a way to just obtain the script from the function reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is specifically for de-stringifying stuff (so that you could "parse" a function reference from what it spits out in
"%{func}%"
) because I thought that'd be a big QoL thing for a lot of users.Ideally you resolve it with a Script reference, but it's possible that it's a local function like
blah() from myscript.sk
in which case you can't just retrieve it with its own name.