Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove non-existing version keyword parameter in script argparser #173

Merged

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Oct 7, 2023

Remove non-existing version keyword parameter in script argument parser object instantiation.

Fixes:

Traceback (most recent call last):
  File ".virtualenvs/wma/lib/python3.8/site-packages/pytest_console_scripts/__init__.py", line 319, in exec_script
    exec(compiled, {'__name__': '__main__'})
  File ".virtualenvs/wma/bin/wm_flatten_length_distribution.py", line 4, in <module>
    __import__('pkg_resources').run_script('whitematteranalysis==0.3.0', 'wm_flatten_length_distribution.py')
  File ".virtualenvs/wma/lib/python3.8/site-packages/pkg_resources/__init__.py", line 666, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File ".virtualenvs/wma/lib/python3.8/site-packages/pkg_resources/__init__.py", line 1462, in run_script
    exec(code, namespace, namespace)
  File ".virtualenvs/wma/lib/python3.8/site-packages/whitematteranalysis-0.3.0-py3.8.egg/EGG-INFO/scripts/wm_flatten_length_distribution.py", line 26, in <module>
    parser = argparse.ArgumentParser(
TypeError: __init__() got an unexpected keyword argument 'version'

and equivalent errors across scripts.

@jhlegarreta jhlegarreta force-pushed the RemoveVersionFromScriptArgParser branch from 5dc2d62 to 287f90d Compare October 7, 2023 16:22
@jhlegarreta
Copy link
Contributor Author

Will help tests pass after #167 and #169 are merged into master.

@jhlegarreta jhlegarreta force-pushed the RemoveVersionFromScriptArgParser branch 2 times, most recently from 60acdc1 to d6742ab Compare October 12, 2023 14:50
Remove non-existing `version` keyword parameter in script argument
parser object instantiation.

Fixes:
```
Traceback (most recent call last):
  File ".virtualenvs/wma/lib/python3.8/site-packages/pytest_console_scripts/__init__.py", line 319, in exec_script
    exec(compiled, {'__name__': '__main__'})
  File ".virtualenvs/wma/bin/wm_flatten_length_distribution.py", line 4, in <module>
    __import__('pkg_resources').run_script('whitematteranalysis==0.3.0', 'wm_flatten_length_distribution.py')
  File ".virtualenvs/wma/lib/python3.8/site-packages/pkg_resources/__init__.py", line 666, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File ".virtualenvs/wma/lib/python3.8/site-packages/pkg_resources/__init__.py", line 1462, in run_script
    exec(code, namespace, namespace)
  File ".virtualenvs/wma/lib/python3.8/site-packages/whitematteranalysis-0.3.0-py3.8.egg/EGG-INFO/scripts/wm_flatten_length_distribution.py", line 26, in <module>
    parser = argparse.ArgumentParser(
TypeError: __init__() got an unexpected keyword argument 'version'
```

and equivalent errors across scripts.
@jhlegarreta jhlegarreta force-pushed the RemoveVersionFromScriptArgParser branch from d6742ab to 743d214 Compare October 12, 2023 16:52
@jhlegarreta jhlegarreta changed the title BUG: Remove non-exisitng version keyword parameter in script argparser BUG: Remove non-existing version keyword parameter in script argparser Oct 12, 2023
@ljod ljod merged commit 5b1f894 into SlicerDMRI:master Oct 19, 2023
0 of 4 checks passed
@jhlegarreta jhlegarreta deleted the RemoveVersionFromScriptArgParser branch October 19, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants