ENH: Improve importing optional packages and modules #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
ImproveImportingOptPackages
branch
from
16d7aaa to
cf4a2ae
Compare
Improve importing optional packages and modules: - Add helper classes and utils to take care of trying to import optional packages, and to provide meaningful information when such packages cannot be imported. - Add the corresponding tests. Prefer using all lowercases for the flags that contain the package/module import success value. Move the `whitematteranalysis/utils.py` module to the `whitematteranalysis/utils/utils.py` module, and remove the `utils` module import from `whitematteranalysis/__init__.py` to avoid module clashes.
jhlegarreta
force-pushed
the
ImproveImportingOptPackages
branch
from
cf4a2ae to
09f78bc
Compare
ljod
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve importing optional packages and modules:
Prefer using all lowercases for the flags that contain the package/module import success value.
Move the
whitematteranalysis/utils.pymodule to thewhitematteranalysis/utils/utils.pymodule, and remove theutilsmodule import fromwhitematteranalysis/__init__.pyto avoid module clashes.