new device (matter-window-covering): Zemismart MT01 #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 51cc5b2 |
ctowns
reviewed
Nov 13, 2023
| @@ -5,7 +5,12 @@ matterManufacturer: | |||
| vendorId: 0x130A | |||
| productId: 0x55 | |||
| deviceProfileName: window-covering-profile | |||
|
|
|||
| #Zemismart | |||
| - id: 5020/65534 | |||
There was a problem hiding this comment.
Indent this line to follow the formatting in the other fingerprints. Also this should be a string (should be surrounded with quotes "").
Where did this ID come from? I am wondering if we can change it to something more human readable? 5020/65534 doesn't really tell us much about what this device is. See above where the id is "Eve MotionBlinds", which makes it clear what we are looking at.
There was a problem hiding this comment.
The partner provided that information, I will need to follow up with the certification tool team regarding that. Thanks Cooper. I made another commit.
|
Channel deleted. |
ctowns
approved these changes
Nov 13, 2023
The window-covering-profile is targeting to no longer be used, this updates to the same profile that is identical but named different. See this comment for more info #1091 (comment)
ctowns
requested changes
Mar 4, 2024
Changing device profile name from "Window-Covering-battery" to "window-covering"
ctowns
approved these changes
Mar 5, 2024
yejinze
added a commit
to yejinze/SmartThingsEdgeDrivers
that referenced
this pull request
Apr 7, 2024
fix aqara gas detector reonboarding issue reference: wash-2068 STSE-2612 Fixed indentation error in the aqara gas detector profile Signed-off-by: Yu Zou <[email protected]> Move write_manufacturer_specific_attribute from added to doConfigure event fix issue that motion detection doesn't work after reonboarding Signed-off-by: Ma Xinjian <[email protected]> Matter Switch: Read color temp and level limits on init When device is initialized, read the color temperature and level cluster min/max and set capability constraint based on the limits. new device (matter-window-covering): Zemismart MT01 (SmartThingsCommunity#1072) * new device/ Zemismart-MT01 * fix indentation, quotes and ID * Update fingerprints.yml The window-covering-profile is targeting to no longer be used, this updates to the same profile that is identical but named different. See this comment for more info SmartThingsCommunity#1091 (comment) * Change profile to not include battery capability Changing device profile name from "Window-Covering-battery" to "window-covering" --------- Co-authored-by: Cooper Towns <[email protected]> CHAD-12648 SmartSense MultiPurpose sensor missing negative temperature handling Co-authored by: Mariano <[email protected]> Matter-Switch: Fixes for color temp limit reads This commit addresses minor issues discovered after PR 1220 was merged into main. fixup: Don't clamp dynamic constraint values It was decided that if values read from the device are outside of the supported capability range, that the capability should not be sent rather than sending the capability with default values. fixup: Resolving luacheck issue Resolving error resulting from luacheck. fixup: Add comment that was accidentally removed Add comment for level range conversion that was removed by accident. fix aqara smoke detector reonboarding issue reference: wash-2068 STSE-2611 Signed-off-by: Ma Xinjian <[email protected]> Add "sane" and default color temp ranges Adds a "sane" color temp range that will be used to determine if range data received from a device is "sane" or not. If not, the values are discarded. Adds a default color range of 2200K-6500K for color temp profiles. Test Coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WWST Certification request to add the Zemismart MT01 window covering device.