Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new device (matter-window-covering): Zemismart MT01 #1072

Merged
merged 6 commits into from
Apr 3, 2024
Merged

new device (matter-window-covering): Zemismart MT01 #1072

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b63e38f
new device/ Zemismart-MT01
lelandblue Nov 13, 2023
0d33287
fix indentation, quotes and ID
lelandblue Nov 13, 2023
97c381a
Update fingerprints.yml
lelandblue Dec 15, 2023
b3356d7
Change profile to not include battery capability
lelandblue Mar 4, 2024
a202fed
Merge branch 'main' into feature/Zemismart-MT01
ctowns Mar 5, 2024
51cc5b2
Merge branch 'main' into feature/Zemismart-MT01
lelandblue Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion drivers/SmartThings/matter-window-covering/fingerprints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ matterManufacturer:
vendorId: 0x130A
productId: 0x55
deviceProfileName: window-covering-profile

#Zemismart
- id: 5020/65534
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent this line to follow the formatting in the other fingerprints. Also this should be a string (should be surrounded with quotes "").

Where did this ID come from? I am wondering if we can change it to something more human readable? 5020/65534 doesn't really tell us much about what this device is. See above where the id is "Eve MotionBlinds", which makes it clear what we are looking at.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The partner provided that information, I will need to follow up with the certification tool team regarding that. Thanks Cooper. I made another commit.

deviceLabel: Zemismart MT01 Slide Curtain
vendorId: 0x139C
productId: 0xFFFE
deviceProfileName: window-covering-profile
matterGeneric:
- id: "windowcovering"
deviceLabel: Matter Window Covering
Expand Down
Loading