Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartSense multipurpose: negative temperature issue #1227

Closed

Conversation

Mariano-Github
Copy link

When the device reports negative temperature values in Int16 data type, the 2's complement of the value sent by the device must be performed

When the device reports negative temperature values in Int16 data type, the 2's complement of the value sent by the device must be performed
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2024

CLA assistant check
All committers have signed the CLA.

@tpmanley
Copy link
Contributor

Good catch @Mariano-Github ! In order to get this merged could you sign the CLA and point the PR against the main branch instead of production? It would also be great if you could add a unit test to https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-contact/src/test/test_smartsense_multi.lua if possible so the negative temperature case is tested.

@Mariano-Github Mariano-Github changed the base branch from production to main February 21, 2024 13:27
@Mariano-Github Mariano-Github changed the base branch from main to production February 21, 2024 13:29
@Mariano-Github Mariano-Github changed the base branch from production to main February 21, 2024 13:30
@Mariano-Github Mariano-Github changed the base branch from main to production February 21, 2024 13:30
@Mariano-Github
Copy link
Author

Hi,
I changed it to the main branch and changes appeared in a file that has nothing to do with it and I left it as it was. Sorry, I don't know how this works.

I don't know what you mean to do with the Test module either.
The changes were tested by a user with a real device, I do not use the test modules

I already signed the CLA

@lelandblue lelandblue requested a review from tpmanley February 21, 2024 14:01
@Mariano-Github
Copy link
Author

Sorry, you can close the pull request and incorporate the modification as best for you.

Greetings

@tpmanley
Copy link
Contributor

Sorry, you can close the pull request and incorporate the modification as best for you.

No worries, @Mariano-Github , we'll take care of getting the fix out. Thanks again for report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants