-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding SAT402ZB Thermostat #1506
Open
gcavalcantistelpro
wants to merge
14
commits into
SmartThingsCommunity:main
Choose a base branch
from
gcavalcantistelpro:SAT402ZB
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8f4d4c2
adding SAT402ZB Thermostat
gcavalcantistelpro f16cef1
Merge branch 'main' into SAT402ZB
gcavalcantistelpro 13639f9
Modifying fingerprints to accomodate maestro
gcavalcantistelpro 0c632c8
Merge branch 'SAT402ZB' of https://github.com/gcavalcantistelpro/Smar…
gcavalcantistelpro ed54c80
Modifying fingerprints to accomodate maestro
gcavalcantistelpro 0ffb3ec
FIXING TYPO
gcavalcantistelpro a2d2460
Merge branch 'main' into SAT402ZB
lelandblue 638d287
SAT402ZB new fingerprint, profile and driver files
gcavalcantistelpro 3e61185
Merge branch 'SAT402ZB' of https://github.com/gcavalcantistelpro/Smar…
gcavalcantistelpro 813ea50
FIXING MODEL ON FINGERPRINTS FILE
gcavalcantistelpro 44c6519
Deleting SAT402ZB subdriver and adding SAT402ZB to stelpro_maestrosta…
gcavalcantistelpro 4ec57d2
Merge branch 'main' into SAT402ZB
gcavalcantistelpro 86ce913
Changing date to 2024
gcavalcantistelpro 71ab154
Merge branch 'SAT402ZB' of https://github.com/gcavalcantistelpro/Smar…
gcavalcantistelpro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
drivers/SmartThings/zigbee-thermostat/profiles/thermostat-stelpro-profile-no-rh.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
name: thermostat-stelpro-profile-no-rh | ||
components: | ||
- id: main | ||
capabilities: | ||
- id: temperatureMeasurement | ||
version: 1 | ||
config: | ||
values: | ||
- key: "temperature.value" | ||
range: [ -20, 100 ] | ||
- id: thermostatHeatingSetpoint | ||
version: 1 | ||
config: | ||
values: | ||
- key: "heatingSetpoint.value" | ||
range: [ 5, 30 ] | ||
- id: thermostatOperatingState | ||
version: 1 | ||
config: | ||
values: | ||
- key: "thermostatOperatingState.value" | ||
enabledValues: | ||
- heating | ||
- idle | ||
- id: temperatureAlarm | ||
version: 1 | ||
config: | ||
values: | ||
- key: "temperatureAlarm.value" | ||
enabledValues: | ||
- cleared | ||
- freeze | ||
- heat | ||
- id: firmwareUpdate | ||
version: 1 | ||
- id: refresh | ||
version: 1 | ||
categories: | ||
- name: Thermostat | ||
preferences: | ||
- name: "lock" | ||
title: "Lock" | ||
description: "Do you want to lock your thermostat's physical keypad?" | ||
required: true | ||
preferenceType: enumeration | ||
definition: | ||
options: | ||
0: "No" | ||
1: "Yes" | ||
default: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @gcavalcantistelpro Thank you for your submission. I would encourage that we focus this change only on adding one new device, the SAT402ZB device. Can you please update the PR to no longer make changes to the "Selpro/MaestroStat"device?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @lelandblue , I've just added a commit for the SAT402ZB thermostat, i left the maestro untouched and added new files for this specific thermostat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @lelandblue , i could validate locally that the device is working after my last commit, please let me know if any further modifications are required on the PR side. Thanks