adding SAT402ZB Thermostat #1506
Conversation
|
Invitation URL: |
Test Results 63 files 397 suites 0s ⏱️ Results for commit 4ec57d2. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4ec57d2 |
| manufacturer: Stelpro | ||
| model: MaestroStat | ||
| model: SMT402AD | ||
| deviceProfileName: thermostat-stelpro-profile |
There was a problem hiding this comment.
Hello @gcavalcantistelpro Thank you for your submission. I would encourage that we focus this change only on adding one new device, the SAT402ZB device. Can you please update the PR to no longer make changes to the "Selpro/MaestroStat"device?
There was a problem hiding this comment.
Hello @lelandblue , I've just added a commit for the SAT402ZB thermostat, i left the maestro untouched and added new files for this specific thermostat
There was a problem hiding this comment.
Hello @lelandblue , i could validate locally that the device is working after my last commit, please let me know if any further modifications are required on the PR side. Thanks
drivers/SmartThings/zigbee-thermostat/src/stelpro/stelpro_maestrostat.lua
Show resolved
Hide resolved
| @@ -0,0 +1,81 @@ | |||
| -- Copyright 2022 SmartThings | |||
| @@ -0,0 +1,479 @@ | |||
| -- Copyright 2022 SmartThings | |||
There was a problem hiding this comment.
Date still needs to be updated.
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
@greens Could you re-review this please? Thank you! |
No description provided.