Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding SAT402ZB Thermostat #1506

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

adding SAT402ZB Thermostat #1506

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8f4d4c2
adding SAT402ZB Thermostat
gcavalcantistelpro Jul 8, 2024
f16cef1
Merge branch 'main' into SAT402ZB
gcavalcantistelpro Jul 16, 2024
13639f9
Modifying fingerprints to accomodate maestro
gcavalcantistelpro Sep 19, 2024
0c632c8
Merge branch 'SAT402ZB' of https://github.com/gcavalcantistelpro/Smar…
gcavalcantistelpro Sep 19, 2024
ed54c80
Modifying fingerprints to accomodate maestro
gcavalcantistelpro Sep 19, 2024
0ffb3ec
FIXING TYPO
gcavalcantistelpro Sep 19, 2024
a2d2460
Merge branch 'main' into SAT402ZB
lelandblue Sep 24, 2024
638d287
SAT402ZB new fingerprint, profile and driver files
gcavalcantistelpro Oct 1, 2024
3e61185
Merge branch 'SAT402ZB' of https://github.com/gcavalcantistelpro/Smar…
gcavalcantistelpro Oct 1, 2024
813ea50
FIXING MODEL ON FINGERPRINTS FILE
gcavalcantistelpro Oct 1, 2024
44c6519
Deleting SAT402ZB subdriver and adding SAT402ZB to stelpro_maestrosta…
gcavalcantistelpro Oct 10, 2024
4ec57d2
Merge branch 'main' into SAT402ZB
gcavalcantistelpro Oct 11, 2024
86ce913
Changing date to 2024
gcavalcantistelpro Oct 22, 2024
71ab154
Merge branch 'SAT402ZB' of https://github.com/gcavalcantistelpro/Smar…
gcavalcantistelpro Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions drivers/SmartThings/zigbee-thermostat/fingerprints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,15 @@ zigbeeManufacturer:
manufacturer: Stelpro
model: ST218
deviceProfileName: thermostat-temperature-temperaturealarm
- id: "Stelpro/MaestroStat"
deviceLabel: Stelpro Thermostat
- id: "Maestro Thermostat"
deviceLabel: Maestro Thermostat
manufacturer: Stelpro
model: MaestroStat
model: SMT402AD
deviceProfileName: thermostat-stelpro-profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gcavalcantistelpro Thank you for your submission. I would encourage that we focus this change only on adding one new device, the SAT402ZB device. Can you please update the PR to no longer make changes to the "Selpro/MaestroStat"device?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lelandblue , I've just added a commit for the SAT402ZB thermostat, i left the maestro untouched and added new files for this specific thermostat

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lelandblue , i could validate locally that the device is working after my last commit, please let me know if any further modifications are required on the PR side. Thanks

- id: "SAT402ZB Thermostat"
gcavalcantistelpro marked this conversation as resolved.
Show resolved Hide resolved
deviceLabel: SAT402ZB Thermostat
manufacturer: Stello
model: HT402
deviceProfileName: thermostat-stelpro-profile
- id: "Stelpro/SORB"
deviceLabel: Stelpro Thermostat
Expand Down
2 changes: 1 addition & 1 deletion drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ local FREEZE_ALRAM_TEMPERATURE = 0
local HEAT_ALRAM_TEMPERATURE = 50

local STELPRO_THERMOSTAT_FINGERPRINTS = {
{ mfr = "Stelpro", model = "MaestroStat" },
{ mfr = "Stello", model = "HT402" },
gcavalcantistelpro marked this conversation as resolved.
Show resolved Hide resolved
{ mfr = "Stelpro", model = "SORB" },
{ mfr = "Stelpro", model = "SonomaStyle" }
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/SmartThings/zigbee-thermostat/src/stelpro/stelpro_maestrostat.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ local Thermostat = clusters.Thermostat
local ThermostatUserInterfaceConfiguration = clusters.ThermostatUserInterfaceConfiguration

local STELPRO_THERMOSTAT_FINGERPRINTS = {
{ mfr = "Stelpro", model = "MaestroStat" },
{ mfr = "Stello", model = "HT402" },
gcavalcantistelpro marked this conversation as resolved.
Show resolved Hide resolved
}

local is_stelpro_thermostat = function(opts, driver, device)
Expand Down
Loading