Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported mode for every operation #1803

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Dec 9, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Spec has the following items.

Cleaning can only be started when the RVC Run Mode cluster’s CurrentMode attribute is set to a
mode that has the Idle mode tag associated with it, and the RVC Operational State cluster’s
OperationalState attribute is set to the Stopped, Paused, Docked or Charging state. #endif::[]

So If it is set to a mode that does not have an idle tag, it should be prevented from switching to a mode that does not have an idle tag because it is not possible.

Summary of Completed Tests

Copy link

github-actions bot commented Dec 9, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Dec 9, 2024

Test Results

   64 files    402 suites   0s ⏱️
2 014 tests 2 014 ✅ 0 💤 0 ❌
3 468 runs  3 468 ✅ 0 💤 0 ❌

Results for commit 0fe21ff.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 9, 2024

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0fe21ff

@HunsupJung HunsupJung force-pushed the update-supported-modes-for-rvc branch from e528030 to 1af7517 Compare December 9, 2024 05:39
Copy link

github-actions bot commented Dec 9, 2024

@HunsupJung HunsupJung force-pushed the update-supported-modes-for-rvc branch from 1af7517 to a4c94c9 Compare December 18, 2024 03:49
Signed-off-by: Hunsup Jung <[email protected]>
@HunsupJung HunsupJung force-pushed the update-supported-modes-for-rvc branch from 3670023 to b356f0d Compare December 18, 2024 05:27
@HunsupJung HunsupJung requested a review from ctowns December 24, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant