-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported mode for every operation #1803
Open
HunsupJung
wants to merge
5
commits into
main
Choose a base branch
from
update-supported-modes-for-rvc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,154
−373
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a4c94c9
Update supported mode for every operation
HunsupJung c320a26
Update test file for matter-rvc
HunsupJung a9076ea
Update clusters
HunsupJung b356f0d
Update embedded device configuration
HunsupJung 0fe21ff
Update test file for matter-rvc
HunsupJung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
drivers/SmartThings/matter-rvc/profiles/rvc-clean-mode.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| name: rvc-clean-mode | ||
| components: | ||
| - id: main | ||
| label: Main | ||
| capabilities: | ||
| - id: robotCleanerOperatingState | ||
| version: 1 | ||
| - id: firmwareUpdate | ||
| version: 1 | ||
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: RobotCleaner | ||
| - id: runMode | ||
| label: Run mode | ||
| capabilities: | ||
| - id: mode | ||
| version: 1 | ||
| categories: | ||
| - name: RobotCleaner | ||
| - id: cleanMode | ||
| label: Clean mode | ||
| capabilities: | ||
| - id: mode | ||
| version: 1 | ||
| categories: | ||
| - name: RobotCleaner | ||
| deviceConfig: | ||
| dashboard: | ||
| states: | ||
| - component: main | ||
| capability: robotCleanerOperatingState | ||
| version: 1 | ||
| detailView: | ||
| - component: main | ||
| capability: robotCleanerOperatingState | ||
| version: 1 | ||
| - component: runMode | ||
| capability: mode | ||
| version: 1 | ||
| patch: | ||
| - op: replace | ||
| path: /0/list/command/supportedValues | ||
| value: supportedArguments.value | ||
| - component: cleanMode | ||
| capability: mode | ||
| version: 1 | ||
| patch: | ||
| - op: replace | ||
| path: /0/list/command/supportedValues | ||
| value: supportedArguments.value | ||
| - component: main | ||
| capability: refresh | ||
| version: 1 | ||
| - component: main | ||
| capability: firmwareUpdate | ||
| version: 1 | ||
| automation: | ||
| conditions: | ||
| - component: runMode | ||
| capability: mode | ||
| version: 1 | ||
| patch: | ||
| - op: replace | ||
| path: /0/displayType | ||
| value: dynamicList | ||
| - op: add | ||
| path: /0/dynamicList | ||
| value: | ||
| value: mode.value | ||
| supportedValues: | ||
| value: supportedModes.value | ||
| - op: remove | ||
| path: /0/list | ||
| - component: cleanMode | ||
| capability: mode | ||
| version: 1 | ||
| patch: | ||
| - op: replace | ||
| path: /0/displayType | ||
| value: dynamicList | ||
| - op: add | ||
| path: /0/dynamicList | ||
| value: | ||
| value: mode.value | ||
| supportedValues: | ||
| value: supportedModes.value | ||
| - op: remove | ||
| path: /0/list | ||
| actions: | ||
| - component: runMode | ||
| capability: mode | ||
| version: 1 | ||
| patch: | ||
| - op: replace | ||
| path: /0/displayType | ||
| value: dynamicList | ||
| - op: add | ||
| path: /0/dynamicList | ||
| value: | ||
| command: setMode | ||
| supportedValues: | ||
| value: supportedModes.value | ||
| - op: remove | ||
| path: /0/list | ||
| - component: cleanMode | ||
| capability: mode | ||
| version: 1 | ||
| patch: | ||
| - op: replace | ||
| path: /0/displayType | ||
| value: dynamicList | ||
| - op: add | ||
| path: /0/dynamicList | ||
| value: | ||
| command: setMode | ||
| supportedValues: | ||
| value: supportedModes.value | ||
| - op: remove | ||
| path: /0/list |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 0 additions & 25 deletions
25
drivers/SmartThings/matter-rvc/src/OperationalState/types/ErrorStateEnum.lua
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 0 additions & 21 deletions
21
drivers/SmartThings/matter-rvc/src/OperationalState/types/ErrorStateStruct.lua
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 0 additions & 25 deletions
25
drivers/SmartThings/matter-rvc/src/OperationalState/types/OperationalStateEnum.lua
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
drivers/SmartThings/matter-rvc/src/OperationalState/types/OperationalStateStruct.lua
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,4 +20,3 @@ end | |
| setmetatable(RvcCleanModeClientCommands, command_mt) | ||
|
|
||
| return RvcCleanModeClientCommands | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,4 +21,3 @@ end | |
| setmetatable(RvcCleanModeServerAttributes, attr_mt) | ||
|
|
||
| return RvcCleanModeServerAttributes | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,4 +84,3 @@ end | |
| setmetatable(ChangeToMode, {__call = ChangeToMode.init}) | ||
|
|
||
| return ChangeToMode | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,4 +20,3 @@ end | |
| setmetatable(RvcCleanModeServerCommands, command_mt) | ||
|
|
||
| return RvcCleanModeServerCommands | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,4 +51,3 @@ end | |
| setmetatable(Feature, new_mt) | ||
|
|
||
| return Feature | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,4 +83,3 @@ end | |
| setmetatable(ModeOptionStruct, new_mt) | ||
|
|
||
| return ModeOptionStruct | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,4 +28,3 @@ end | |
| setmetatable(ModeTag, new_mt) | ||
|
|
||
| return ModeTag | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,4 +75,3 @@ end | |
| setmetatable(ModeTagStruct, new_mt) | ||
|
|
||
| return ModeTagStruct | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,4 +22,3 @@ end | |
| setmetatable(StatusCode, new_mt) | ||
|
|
||
| return StatusCode | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,4 +12,3 @@ local RvcCleanModeTypes = {} | |
| setmetatable(RvcCleanModeTypes, types_mt) | ||
|
|
||
| return RvcCleanModeTypes | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HunsupJung I'm not super familiar with this profile handling. what is this supposed to be doing for the device card?