Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new AQS profile for Matter Sensor #1821

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

hcarter-775
Copy link
Contributor

@hcarter-775 hcarter-775 commented Dec 11, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

See MTR-864. This device in testing now does not perfectly map to any of our profiles and so this new profile will handle this device.

Further, since I was looking at the test file, I re-organized it a little to future proof it and keep it from getting to unwieldy.

Summary of Completed Tests

Tested with a new unit test using the same cluster configuration.

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@nickolas-deboom
Copy link
Contributor

Looks good to me!

Copy link
Contributor

@ctowns ctowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new helper functions for the unit tests look beautiful, good work! 🤩

@hcarter-775 hcarter-775 merged commit b2fa5b4 into main Dec 17, 2024
10 checks passed
@hcarter-775 hcarter-775 deleted the add-aqs-tvoc-profile branch December 17, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants