Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement Keypoint filtering using a cv::Mat #46

Closed
wants to merge 4 commits into from

Conversation

Soldann
Copy link
Owner

@Soldann Soldann commented Jul 5, 2022

Description & Motivation

Fixes #9

We are adding orb-filtering from a cv::Mat mask to allow for future refinements such as filtering moving objects out of the SLAM algorithm.

Changes made

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes

This adds a mask argument to the Frame, Tracking, and System classes. It also creates an override in ORBExtractor for both masked and non-masked versions of a frame.

To specify no mask, pass nullptr as the mask argument instead of the address of a cv::Mat.

THIS IS BREAKING: old examples will not run without adding the mask argument (can use nullptr).

Test Plan

Ran a local test on the Jetson Orin and verified ORBS were not obtained outside of the mask.

Test Configuration:

  • Hardware: Jetson Orin

Will need to do a second test to verify integrity of the SLAM algorithm

Test Configuration:

  • Hardware:

@Soldann Soldann added the needs validation Further testing required label Jul 5, 2022
@Soldann Soldann marked this pull request as ready for review July 5, 2022 13:58
@Ryan-Red Ryan-Red added the duplicate This issue or pull request already exists label Jul 21, 2022
@Ryan-Red
Copy link
Collaborator

Marked as duplicate, new and improved PR: #65

@Ryan-Red Ryan-Red closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists needs validation Further testing required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Orbs using a cv::Mat
3 participants