Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased Feature: Implement keypoint filtering with cv::Mat #65

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Soldann
Copy link
Owner

@Soldann Soldann commented Jul 14, 2022

This is a rebased version of #46

Description & Motivation

Fixes #9

We are adding orb-filtering from a cv::Mat mask to allow for future refinements such as filtering moving objects out of the SLAM algorithm.

What is the issue is addressed? Please also include relevant motivation and context.

Changes made

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes

This adds a mask argument to the Frame, Tracking, and System classes. It also creates an override in ORBExtractor for both masked and non-masked versions of a frame.

To specify no mask, pass nullptr as the mask argument instead of the address of a cv::Mat.

THIS IS BREAKING: old examples will not run without adding the mask argument (can use nullptr).

Test Plan

Ran a local test on the Jetson Orin and verified ORBS were not obtained outside of the mask.

Test Configuration:

Hardware: Jetson Orin

Will need to do a second test to verify integrity of the SLAM algorithm

Test Configuration:

Hardware:

@Soldann
Copy link
Owner Author

Soldann commented Jul 21, 2022

Did some testing and this works fine in RGBD but causes segmentation faults in Stereo. Cannot find the cause as of now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Orbs using a cv::Mat
2 participants