make the lack of address book non-fatal when listing groups #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
reviewed
Aug 28, 2024
| @@ -87,7 +87,8 @@ export async function renderGroupMemberships (person, context) { | |||
| if (!book) { | |||
| book = kb.any(undefined, ns.vcard('includesGroup')) | |||
| if (!book) { | |||
| throw new Error('findBookFromGroups: Cant find address book which this group is part of') | |||
| // throw new Error('findBookFromGroups: Cant find address book which this group is part of') | |||
There was a problem hiding this comment.
Wrapping things in single-quotes should not turn can't into cant, which is a distinct word with a different meaning. Either the enclosed apostrophe should be escaped, or it should be rephrased, as here --
Suggested change
| // throw new Error('findBookFromGroups: Cant find address book which this group is part of') | |
| // throw new Error('findBookFromGroups: Cannot find address book which this group is part of') |
(I know this is now commented out, but as long as it's retained in the code, it should be as correct as possible.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #87