Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the lack of address book non-fatal when listing groups #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make the lack of address book non-fatal when listing groups #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion groupMembershipControl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ export async function renderGroupMemberships (person, context) {
if (!book) {
book = kb.any(undefined, ns.vcard('includesGroup'))
if (!book) {
throw new Error('findBookFromGroups: Cant find address book which this group is part of')
// throw new Error('findBookFromGroups: Cant find address book which this group is part of')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping things in single-quotes should not turn can't into cant, which is a distinct word with a different meaning. Either the enclosed apostrophe should be escaped, or it should be rephrased, as here --

Suggested change
// throw new Error('findBookFromGroups: Cant find address book which this group is part of')
// throw new Error('findBookFromGroups: Cannot find address book which this group is part of')

(I know this is now commented out, but as long as it's retained in the code, it should be as correct as possible.)

return // no book => no groups
}
}
const groupIndex = kb.any(book, ns.vcard('groupIndex'))
Expand Down
Loading