-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding makefile to install first pre-commit and then venv #29
Conversation
boekhorstb1
commented
Mar 7, 2024
- adding makefile with pre-commit installation first and then venv installation
3b35c50
to
a13c13e
Compare
be90a2e
to
b713898
Compare
b713898
to
9fb8b51
Compare
in README.md Signed-off-by: R.A. te Boekhorst <[email protected]>
9fb8b51
to
0cd9ec5
Compare
I did a little bit research. So I think the best solution for the rados library is:
For explanation: The only problem this cannot resolve is, that a developer could import a package, that is installed as system package on the development machine and so, don't notice that the requirements.txt has to be updated. But this is a problem we can resolve by checking in a CI/CD pipeline |
…ackage Signed-off-by: R.A. te Boekhorst <[email protected]>
… it checks if rados is installed locally in the correct way Signed-off-by: R.A. te Boekhorst <[email protected]>
…requirements Signed-off-by: R.A. te Boekhorst <[email protected]>