Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4976: Fix EnrollOnBehalfOf logic issue #937

Closed
wants to merge 6 commits into from
Closed

Conversation

JonasBK
Copy link
Contributor

@JonasBK JonasBK commented Nov 7, 2024

Description

Fixed a bug in the EnrollOnBehalfOf logic.

We now correctly check if the CA of the first CertTemplate is trusted for NTAuth.

Fixed harness tests to account for this as well.

Motivation and Context

This PR addresses: BED-4976

How Has This Been Tested?

Fixed harness tests for EnrollOnBehalfOf.

Checked that the edge is still generated and composition works for ESC3 with this dataset:
20231208161111_BloodHound.zip

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@JonasBK JonasBK added bug Something isn't working external This pull request is from an external contributor labels Nov 7, 2024
@JonasBK JonasBK enabled auto-merge (squash) November 7, 2024 10:35
@JonasBK JonasBK added the ticketed (automation only) Ticket has been created internally for tracking label Nov 7, 2024
@JonasBK JonasBK mentioned this pull request Dec 9, 2024
3 tasks
@JonasBK JonasBK closed this Dec 9, 2024
auto-merge was automatically disabled December 9, 2024 18:27

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working external This pull request is from an external contributor ticketed (automation only) Ticket has been created internally for tracking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants