Skip to content

Patch to support Quad-Base naming in read_openephys #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alejoe91
Copy link
Member

This PR refines the logic to find probe names from Open-Ephys streams.

In particular, the Quad Base Neuropixels probes produces 4 streams (one for each shank), which are named {probe_name}-1/2/3/4. Our previous logic, splitting everything by -, didn't work.
The new logic only skips the -AP/-LFP substrings

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (c96510c) to head (daba846).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   89.66%   89.68%   +0.02%     
==========================================
  Files          12       12              
  Lines        1954     1958       +4     
==========================================
+ Hits         1752     1756       +4     
  Misses        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant