feat(menu.module.css): padding to category to fix active highlighting #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhender
requested review from
melissasamworth,
mruwnik,
ccstan99 and
buddy-web3
and removed request for
ccstan99
melissasamworth
approved these changes
Feb 14, 2024
| @@ -15,6 +15,7 @@ | |||
| align-items: flex-start; | |||
| margin: 5px; | |||
| position: relative; | |||
| padding: 0px 10px 0px 24px; | |||
There was a problem hiding this comment.
We're trying to use variables when we define numbers. Partially for conversion to mobile, partially so we can avoid numbers that aren't in the design system like 10px. If you want you can change these but I'll still approve :).
There was a problem hiding this comment.
Ok, thanks. I'll adjust this PR to have variables and numbers that are in the design system.
If you want to merge to get the change on stampy-redesign though, go ahead and I can make the change in another PR.
|
Closing as categories page is in a good state AFAIK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #379 . Adds padding so that active category is closer to figma