Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(menu.module.css): padding to category to fix active highlighting #402

Closed
wants to merge 1 commit into from
Closed

feat(menu.module.css): padding to category to fix active highlighting #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/CategoriesNav/menu.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
align-items: flex-start;
margin: 5px;
position: relative;
padding: 0px 10px 0px 24px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to use variables when we define numbers. Partially for conversion to mobile, partially so we can avoid numbers that aren't in the design system like 10px. If you want you can change these but I'll still approve :).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. I'll adjust this PR to have variables and numbers that are in the design system.
If you want to merge to get the change on stampy-redesign though, go ahead and I can make the change in another PR.

}
.categoryAutoLayoutHorizontal.active {
background-color: rgba(237.0000010728836, 250.00000029802322, 249.00000035762787, 1);
Expand Down
Loading