Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(centraldash): fix quickling broken on params #243

Open
wants to merge 12 commits into
base: KF1.9-main
Choose a base branch
from
Open

fix(centraldash): fix quickling broken on params #243

wants to merge 12 commits into from

Conversation

wg102
Copy link

@wg102 wg102 commented Jan 30, 2025

@wg102 wg102 added the auto-deploy Trigger manual CI steps for this CI label Jan 30, 2025
@wg102 wg102 changed the title test with type fix(centraldash): fix quickling broken on params Jan 30, 2025
@wg102 wg102 marked this pull request as ready for review January 30, 2025 18:16
@wg102
Copy link
Author

wg102 commented Jan 30, 2025

Note: failed test expected until configmap is fixed/updated

mathis-marcotte
mathis-marcotte approved these changes Jan 31, 2025
View reviewed changes
Copy link

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making me think that we should just display the namespace at the top left of the page as just a label instead of a dropdown, if we aren't using contributors. But anyways that would be for a different PR, so this lgtm

mathis-marcotte
mathis-marcotte requested changes Jan 31, 2025
View reviewed changes
Copy link

@mathis-marcotte mathis-marcotte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just noticed the failed cypress test. You need to update the "dashboard-links" fixture in our Cypress files. The cypress tests are not reading the configmaps on the cluster from what I remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathis-marcotte mathis-marcotte mathis-marcotte requested changes

Assignees
No one assigned
Labels
auto-deploy Trigger manual CI steps for this CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wg102 @mathis-marcotte