Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(centraldash): fix quickling broken on params #243

Merged
merged 14 commits into from
Feb 3, 2025
+50 −46
Merged

fix(centraldash): fix quickling broken on params #243

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
48262fb
test with type
wg102 Jan 30, 2025
98be710
Add console to debue
wg102 Jan 30, 2025
bfa9f9a
Add second console log
wg102 Jan 30, 2025
6cb0d12
fix statement
wg102 Jan 30, 2025
40ae7b3
Another console
wg102 Jan 30, 2025
95cd9df
remove the buildhref
wg102 Jan 30, 2025
dc070ef
Remove the entire quicklink remaping function
wg102 Jan 30, 2025
a832cfc
fix code
wg102 Jan 30, 2025
5a1fc55
spelling issue
wg102 Jan 30, 2025
1142e02
umdo changes
wg102 Jan 30, 2025
d734868
fix test
wg102 Jan 30, 2025
a28eea9
temp fix
wg102 Jan 30, 2025
0ab5069
Update cypress tests
wg102 Feb 3, 2025
75e0cc9
Update main-page.cy.ts
mathis-marcotte Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
temp fix
@wg102
wg102 committed Jan 30, 2025
commit a28eea9c225c5a97d78be4febfdb4f834619b9d9
2 changes: 1 addition & 1 deletion components/centraldashboard/cypress/e2e/main-page.cy.ts
View file
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ describe('Main Page', () => {
cy.get('main-page').shadow().find('dashboard-view').should('exist');
// create new notebook link
cy.get('main-page').shadow().find('dashboard-view').shadow().find('paper-card#Quick-Links').should('exist');
cy.get('main-page').shadow().find('dashboard-view').shadow().find('paper-card#Quick-Links').find('iframe-link').should('exist').and('have.length', 1).and('have.prop', 'href', '/en/new?ns={ns}');
cy.get('main-page').shadow().find('dashboard-view').shadow().find('paper-card#Quick-Links').find('iframe-link').should('exist').and('have.length', 1).and('have.prop', 'href', '/en/new');
cy.get('main-page').shadow().find('dashboard-view').shadow().find('paper-card#Quick-Links').find('iframe-link').find('div.header').should('have.text', 'Create a new Notebook server');
// documentation links
cy.get('main-page').shadow().find('dashboard-view').shadow().find('paper-card#Documentation').should('exist');