Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archiver to uv #153

Merged
merged 10 commits into from
Feb 25, 2025
Merged

Update archiver to uv #153

merged 10 commits into from
Feb 25, 2025

Conversation

phwissmann
Copy link
Collaborator

@phwissmann phwissmann commented Feb 19, 2025

A couple of maintenance items:

  • Introduce UV also in the archiver in order to aligned with the rest of the repository
    - Use specific and configurable user in docker container that writes to/reads from the LTS; these are the permission flags set on the files in the LTS and therefore need to be consistent
  • Improved CI by adding test report and run steps conditionally

@phwissmann phwissmann force-pushed the update-archiver-to-uv branch 11 times, most recently from ca355ad to 0713d5c Compare February 21, 2025 16:20
@phwissmann phwissmann force-pushed the update-archiver-to-uv branch 2 times, most recently from d337a8e to 2650966 Compare February 21, 2025 17:16
@phwissmann phwissmann linked an issue Feb 21, 2025 that may be closed by this pull request
@phwissmann phwissmann force-pushed the update-archiver-to-uv branch 3 times, most recently from 99daf28 to 4a71c38 Compare February 24, 2025 08:10
@phwissmann phwissmann self-assigned this Feb 24, 2025
@pulsargranular
Copy link
Collaborator

Although I don't understand everything, it looks good to me!
I would suggest to move all the prefect stuff in its own folder, so we can get rid of some file prefixes, e.g.

  • prefect-config.py
  • prefect-vars.toml
  • prefect-config.Dockerfile

Copy link
Collaborator

@pulsargranular pulsargranular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes in this PR and only a few of them are related to «update archiver to uv».

@phwissmann phwissmann force-pushed the update-archiver-to-uv branch 3 times, most recently from 9d5239e to 3a88074 Compare February 24, 2025 16:35
@phwissmann
Copy link
Collaborator Author

Lots of changes in this PR and only a few of them are related to «update archiver to uv».

Move out important changes to new PR #154

@phwissmann
Copy link
Collaborator Author

Although I don't understand everything, it looks good to me! I would suggest to move all the prefect stuff in its own folder, so we can get rid of some file prefixes, e.g.

  • prefect-config.py
  • prefect-vars.toml
  • prefect-config.Dockerfile

Makes sense. Done.

@phwissmann phwissmann force-pushed the update-archiver-to-uv branch 3 times, most recently from b975829 to c74e958 Compare February 24, 2025 16:47
@phwissmann phwissmann force-pushed the update-archiver-to-uv branch from c74e958 to 0467d7d Compare February 24, 2025 16:54
@phwissmann phwissmann force-pushed the update-archiver-to-uv branch from 0467d7d to b455060 Compare February 24, 2025 17:01
@phwissmann phwissmann merged commit df4c8b5 into main Feb 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants