Create Gmv Command PoC #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpysiak
force-pushed
the
create-gmv-command
branch
from
d7a0701
to
15a38de
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
15a38de
to
79e1fc1
Compare
GSadee
reviewed
Jun 18, 2024
mpysiak
force-pushed
the
create-gmv-command
branch
4 times, most recently
from
2bd7e36
to
3b276ae
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
3b276ae
to
21f832a
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
399f47b
to
c14d738
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
c14d738
to
dced02b
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
3 times, most recently
from
ee28d53
to
2ab6dd6
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
2 times, most recently
from
51e438d
to
0d37ebf
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
3 times, most recently
from
28fdb46
to
59d587d
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
59d587d
to
8a4ebef
Compare
TheMilek
reviewed
Jun 25, 2024
Wojdylak
reviewed
Jun 25, 2024
src/Parser/DateParser.php
Outdated
| $now = new \DateTime(); | ||
|
|
||
| return (clone $now) | ||
| ->modify('first day of -12 months'); |
There was a problem hiding this comment.
It would be nice to have configurable parameters for the default start date and default end date.
GSadee
reviewed
Jun 26, 2024
| <argument type="service" id="sylius_gmv.validator.input_parameters" /> | ||
| <argument type="service" id="sylius_gmv.parser.date" /> | ||
| <argument type="service" id="sylius_gmv.provider.gmv" /> | ||
| <tag name="console.command" command="sylius:gmv:calculate" /> |
There was a problem hiding this comment.
Is this tag needed as there is AsCommand attribute configured?
There was a problem hiding this comment.
If I remove this tag. All private services are removed from container, and it creates problems in tests
src/Parser/DateParserInterface.php
Outdated
Comment on lines
18
to
24
| public function parseStartOfMonth(string $date): \DateTime; | ||
|
|
||
| public function parseEndOfMonth(string $date): \DateTime; | ||
|
|
||
| public function getDefaultStartDate(): \DateTime; | ||
|
|
||
| public function getDefaultEndDate(): \DateTime; |
There was a problem hiding this comment.
Suggested change
| public function parseStartOfMonth(string $date): \DateTime; | |
| public function parseEndOfMonth(string $date): \DateTime; | |
| public function getDefaultStartDate(): \DateTime; | |
| public function getDefaultEndDate(): \DateTime; | |
| public function parseStartOfMonth(string $date): \DateTimeInterface; | |
| public function parseEndOfMonth(string $date): \DateTimeInterface; | |
| public function getDefaultStartDate(): \DateTimeInterface; | |
| public function getDefaultEndDate(): \DateTimeInterface; |
There was a problem hiding this comment.
Using DateTimeInterface triggers php error during mocking this service
mpysiak
force-pushed
the
create-gmv-command
branch
from
ddc97de
to
3aec3aa
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
3aec3aa
to
19bc7b8
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
20e84a4
to
62ae1d4
Compare
mpysiak
force-pushed
the
create-gmv-command
branch
from
62ae1d4
to
ab3141b
Compare
GSadee
reviewed
Jun 27, 2024
| expensive_sw_mug_item_unit4: | ||
| __construct: [ "@expensive_sw_mug_item_2" ] | ||
|
|
||
| Sylius\Component\Core\Model\Adjustment: |
There was a problem hiding this comment.
To test both, excluded and included taxes, configure also some not neutral tax adjustments 🖖🏻
There was a problem hiding this comment.
And what about promotions? They do not affect the calculation because we sum up the total items in the order, am I correct?
GSadee
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.