Feat/add get balance #77
Conversation
kirahsapong
force-pushed
the
feat/add-get-balance
branch
from
f51bf39 to
e13c384
Compare
kirahsapong
requested review from
jiyoonie9,
angiejones and
nitro-neal
as code owners
| @@ -9,7 +9,7 @@ final class tbDEXTestVectorsProtocol: XCTestCase { | |||
|
|
|||
| // MARK: - Resources | |||
|
|
|||
| func test_parseOffering() throws { | |||
| func _test_parseOffering() throws { | |||
There was a problem hiding this comment.
is there a swift-related reason for the _ prefix here?
There was a problem hiding this comment.
you mentioned - but yeah means skip this
There was a problem hiding this comment.
tests must be prefixed with test so really anything would do
| @@ -83,6 +83,27 @@ final class tbDEXHttpClientTests: XCTestCase { | |||
| XCTAssertNotNil(offerings[0].signature) | |||
| } | |||
|
|
|||
| func test_getBalancesWithOneValidBalance() async throws { | |||
There was a problem hiding this comment.
could we add all the failure test cases similar to what you did in TBD54566975/tbdex-js#212 ?
There was a problem hiding this comment.
some of these tests end up testing a ton of duplicative functionality, so was planning to refactor the source code into a shared private function (made a note at top of the file). wdyt?
There was a problem hiding this comment.
opened an issue to track here - #85
| return parsedBalance | ||
| } | ||
|
|
||
| let balancePrettyJSON = """ |
There was a problem hiding this comment.
ah, maybe _ prefix means they are skipped? i am inferring this test suite is wip
There was a problem hiding this comment.
yes thats right 👍 good intuition
closes #56