Add gsw infunnel #60
Merged
Add gsw infunnel #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
force-pushed
the
add_gsw_infunnel
branch
3 times, most recently
from
27adbb3
to
3b06efd
Compare
|
@efiring I tested using some random values and comparing against the Matlab version. Seems to work but I'm not a c programmer, in fact I never tried anything in C until this function. I believe the actual function is OK but the tests are definitely kind of strange when compared with the rest of the tests in there. I'd love to get this into both R and Python wrappers though. Let me know what you think. |
ocefpaf
force-pushed
the
add_gsw_infunnel
branch
from
7156f77
to
fe3ea51
Compare
@efiring let me know if there is anything else we need to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the infunnel function ported from the Matlab version.