Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

на ревью #33

Closed
wants to merge 18 commits into from
Closed

на ревью #33

wants to merge 18 commits into from

Conversation

maleyvich
Copy link

Описание изменений

Почему и что этот ПР улучшит

Авторство

Чеинжлог

Copy link
Member

@AzzyDreemurr13 AzzyDreemurr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У тебя по чекеру завал, иди смотри

code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
@AzzyDreemurr13 AzzyDreemurr13 added the Внутрений ревью ПР находиться на внутренем ревью в разделе Pull Requests label May 24, 2024
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
if(STATE_CALLSHUTTLE)
dat += "Are you sure you want to call the shuttle? <A HREF='?src=\ref[src];operation=callshuttle2'>OK</A> | <A HREF='?src=\ref[src];operation=main'>Cancel</A>"
dat += "Вы уверены, что хотите вызвать шаттл? <A HREF='?src=\ref[src];operation=callshuttle2'>ДА</A> | <A HREF='?src=\ref[src];operation=main'>ОТМЕНА</A>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dat += "Вы уверены, что хотите вызвать шаттл? <A HREF='?src=\ref[src];operation=callshuttle2'>ДА</A> | <A HREF='?src=\ref[src];operation=main'>ОТМЕНА</A>"
dat += "Вы уверены, что хотите вызвать шаттл? <A HREF='?src=\ref[src];operation=callshuttle2'>Да</A> | <A HREF='?src=\ref[src];operation=main'>Нет</A>"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не знаю в чем проблема?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Странно звучит, я решил всё в единый формат

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тогда большими буквами, там как раз они и были и были в контексте

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Ок иностранцы всегда любят писать большими, вообще не признак

if(STATE_CANCELSHUTTLE)
dat += "Are you sure you want to cancel the shuttle? <A HREF='?src=\ref[src];operation=cancelshuttle2'>OK</A> | <A HREF='?src=\ref[src];operation=main'>Cancel</A>"
dat += "Вы уверены, что хотите отозвать шаттл? <A HREF='?src=\ref[src];operation=cancelshuttle2'>ДА</A> | <A HREF='?src=\ref[src];operation=main'>НЕТ</A>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dat += "Вы уверены, что хотите отозвать шаттл? <A HREF='?src=\ref[src];operation=cancelshuttle2'>ДА</A> | <A HREF='?src=\ref[src];operation=main'>НЕТ</A>"
dat += "Вы уверены, что хотите отозвать шаттл? <A HREF='?src=\ref[src];operation=cancelshuttle2'>Да</A> | <A HREF='?src=\ref[src];operation=main'>Нет</A>"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

аналогично

code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/communications.dm Outdated Show resolved Hide resolved
AzzyDreemurr13
AzzyDreemurr13 previously approved these changes May 24, 2024
Copy link
Member

@AzzyDreemurr13 AzzyDreemurr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Разрешаю на тау кидать перевод

@AzzyDreemurr13
Copy link
Member

Перенесли на Тау

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Внутрений ревью ПР находиться на внутренем ревью в разделе Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Перевод интерфейса консоли мостика
3 participants