[feat] 식당 Id로 메뉴 목록 불러오기 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public MenusGetResponse getMenus(final long storeId) { | ||
| Store findStore = storeFinder.findByIdWhereDeletedIsFalse(storeId); | ||
| List<Menu> findmenus = menuFinder.findAllByStore(findStore); | ||
| List<MenuGetResponse> menus = findmenus.stream() |
There was a problem hiding this comment.
Entity -> DTO 변환로직이니 DTO에 있어도 되지 않을까 생각을 해봅니다.. 👀
| @@ -42,4 +43,9 @@ public HankkiResponse<MenusPostResponse> createMenu(@PathVariable final Long sto | |||
| .toList(); | |||
| return HankkiResponse.success(CommonSuccessCode.CREATED, menuCommandService.createMenus(MenusPostCommand.of(storeId, command))); | |||
| } | |||
|
|
|||
| @GetMapping("{storeId}/menus") | |||
There was a problem hiding this comment.
혹시 맨앞에 /를 생략하신 이유가 있으실까요? 제가 모르는 부분이 있나 싶어서 여쭤보아요
| @Valid @RequestBody final List<MenuPostRequest> request) { | ||
| @PostMapping("/{storeId}/menus/bulk") | ||
| public HankkiResponse<MenusPostResponse> createMenu(@PathVariable @Min(value = 1L) final long storeId, | ||
| @Valid @RequestBody final List<MenuPostRequest> request) { | ||
| List<MenuPostCommand> command = request.stream() |
There was a problem hiding this comment.
이 변환과정 자체도 dto에 있어도 될 것 같아여
| List<MenuGetResponse> findmenus = menus.stream() | ||
| .map(MenuGetResponse::of) | ||
| .toList(); | ||
| return new MenusGetResponse(findmenus); |
There was a problem hiding this comment.
매개변수에 바로 안넣고 변수 따로 생성해서 넣는 이유가 궁금해여
|
|
||
| import org.hankki.hankkiserver.domain.menu.model.Menu; | ||
|
|
||
| public record MenuGetResponse ( |
There was a problem hiding this comment.
이 DTO는 지금 MenusGetResponse에서만 사용하고 있는 것 같은데 접근제어자 public말고 default로 해줘도 될 것 같슴둥
| int price, | ||
| String name | ||
| ){ | ||
| public static MenuGetResponse of(final Menu menu) { |
There was a problem hiding this comment.
얘도 default여도 될 것 같아유
kgy1008
commented
Nov 12, 2024
| @Getter | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Table(name = "deleted_menu") | ||
| public class DeletedMenu extends BaseCreatedAtEntity { |
Comment on lines
75
to
85
| private void checkNoMenuInStore(final Store store, final long userId, final Menu menu) { | ||
| if (!menuFinder.existsByStoreId(store.getId())) { | ||
| storeUpdater.deleteStore(store.getId()); | ||
| DeletedMenu deletedMenu = convertToDeletedMenu(menu, store.getId()); | ||
| deletedMenuUpdater.save(deletedMenu); | ||
| publisher.publish(DeleteStoreEvent.of(store.getName(), userId)); | ||
| } | ||
| } | ||
|
|
||
| private DeletedMenu convertToDeletedMenu(final Menu menu, final long storeId) { | ||
| return DeletedMenu.create(menu.getName(), menu.getPrice(), storeId); |
There was a problem hiding this comment.
이 부분 추가 된 곳 -> 메뉴 없을 때, 식당 삭제하고 삭제된 메뉴 deletedMenu 형태로 바꾼 후, 해당 테이블에 저장
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #217
Description ✔️
To Reviewers
API 테스트 완료
