Winds patch 3 #1214
Merged
Winds patch 3 #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2024 10:59
… and added Merritt2024 mass loss wrapper
jeffriley
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Thanks JD. Looks good - just a question and a request:
(1) Since the call to CalculateMassLossRateHurley() in Remnants.h sets mass loss to 0,0, should we also set m_DominantMassLossRate = MASS_LOSS_TYPE::NONE there?
(2) Can you update the online documentation for dominant mass loss rate to reflect the current values? (In standard-logfiles-record-specification-stellar.rst (under "COMPAS output"))
|
Thanks Jeff, let me know if this looks good. |
jeffriley
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Looks good - thanks JD.
I'll approve - up to @ilyamandel now.
ilyamandel
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #1209 we set mass loss to 0 in Remnants.h, and set the Dominant mass loss rate tag to
NONEfor both Belczynski2010 and Merritt2024.Previously, WD experienced WR mass loss. AGB/post-AGB still experience either GB, MS, or WR winds, depending on mass and radial change fraction settings and initial mass.