Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winds patch 3 #1214

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Winds patch 3 #1214

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0782a73
set mass loss to 0, and Dominant mass loss rate to NONE for remnants,…
Sep 5, 2024
d2e9c08
changelog
Sep 5, 2024
bce3c03
updated Hurley as well
Sep 5, 2024
779453f
updated DMLR tags in the logfiles docs
Sep 5, 2024
a926117
Update changelog.h
ilyamandel Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ges/User guide/COMPAS output/standard-logfiles-record-specification-stellar.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,17 +381,17 @@ Following is an alphabetical list of stellar properties available for inclusion

* - None
- = 0
* - Nieuwenhuijzen and de Jager
* - GB (Giant Branch)
- = 1
* - Kudritzki and Reimers
* - LBV (Luminous Blue Variable)
- = 2
* - Vassiliadis and Wood
* - OB (Main Sequence)
- = 3
* - Wolf-Rayet-like (Hamann, Koesterke and de Koter)
* - RSG (Red Supergiant)
- = 4
* - Vink
* - VMS (Very Massive Main Sequence)
- = 5
* - Luminous Blue Variable
* - WR (Wolf-Rayet)
- = 6

* - Header Strings:
Expand Down
5 changes: 3 additions & 2 deletions src/Remnants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@ class Remnants: virtual public BaseStar, public HeGB {
const double p_AccretorMassRate,
const bool p_IsHeRich) { return CalculateMassAcceptanceRate(p_DonorMassRate, p_AccretorMassRate); } // Ignore the He content for non-WDs

double CalculateMassLossRateHurley() { return 0.0; }
double CalculateMassLossRateBelczynski2010() { return 0.0; }
double CalculateMassLossRateHurley() { m_DominantMassLossRate = MASS_LOSS_TYPE::NONE ; return 0.0; }
double CalculateMassLossRateBelczynski2010() { m_DominantMassLossRate = MASS_LOSS_TYPE::NONE ; return 0.0; }
double CalculateMassLossRateMerritt2024() { m_DominantMassLossRate = MASS_LOSS_TYPE::NONE ; return 0.0; } //

double CalculatePerturbationMuOnPhase() const { return m_Mu; } // NO-OP

Expand Down
5 changes: 3 additions & 2 deletions src/changelog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,8 +1285,9 @@
// See "What's New" and option documentation for details.
// (Issue #1170)
// - added deprecation notice for '--mass-loss-prescription NONE' (should use ZERO) - missed in v03.00.00
// 03.01.07 JDM - Sep 5, 2024 - Defect repair:
// - Set mass loss for remnants to zero.


const std::string VERSION_STRING = "03.01.06";
const std::string VERSION_STRING = "03.01.07";

# endif // __changelog_h__
Loading