Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate image loading from Picasso to Coil #11238

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Migrate image loading from Picasso to Coil #11238

merged 13 commits into from
Aug 7, 2024

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Migrate the image loading functionality from Picasso to Coil. Picasso has not had a new release for some time, and it has been recommended to move to other libraries. Coil also allows the notification icon loading to be greatly simplified, and it provides default configurations for its memory and disk caches.
  • Remove the image indicator toggle from the settings as Coil does not have that functionality. Logging has been enabled instead for debug builds.
  • Enable RGB-565 support for low-RAM devices only.
  • This change is needed for PR Migrate comment fragments to Jetpack Compose #11060 as it makes use of Coil's Compose functionality.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Jul 5, 2024
This was referenced Jul 5, 2024
Open
Draft
Stypox
Stypox requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to review :-(
Looks mostly good to me, thank you!

app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/player/Player.java Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/player/Player.java Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/util/external_communication/ShareUtils.java Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarCloud

@Isira-Seneviratne Isira-Seneviratne mentioned this pull request Aug 1, 2024
Merged
5 tasks
Stypox
Stypox approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Stypox Stypox merged commit d336f4c into TeamNewPipe:refactor Aug 7, 2024
6 checks passed
@ShareASmile ShareASmile added the rewrite Issues and PRs related to rewrite label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
rewrite Issues and PRs related to rewrite size/giant PRs with more than 750 changed lines
Projects
Rewrite
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isira-Seneviratne @Stypox @ShareASmile