-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to skip transcriptome quantification #17
base: master
Are you sure you want to change the base?
Conversation
Thanks for this. Can you show that this gives equivalent quantification for the assembled sequences when compared with making an index from the whole transcriptome? It was always my concern that having so few sequences in the index would violate assumptions in the Kallisto/Salmon quantification models and so would give spurious quants. For an alternative way to solve this same problem, have a look at the PS - apologies for not accepting your CI pull request. I've been travelling and haven't had chance to look at it. Hoping to do so this week. |
@mstubb - the quantification will be different. My thought is that this option would be for those who are performing mapping / quantification by another method e.g. STAR + htseq and are not interested in the pseudoalignment transcriptome counts. We could explicitly write |
That makes sense although worth noting that the quantifications are used to filter the reconstructed sequences in cases where more than two recombinants are detected for a particular locus (eg 3 Igh sequences). The two most highly expressed are assumed to be the 'correct' ones. If we implemented this we'd need to show that the ranking by expression of the recombinants was the same even if the TPMs were wildly different. Or, only allow this mode to be used without attempting any filtering. |
I agree that filtering is useful and agree that we would want to demonstrate that ignoring the transcriptome doesn't affect recombinant selection. To verify this I've created a test where I've added the following to the fastq reads of
The TPM results from
The raw TPM numbers are much higher without the transcriptome as expected, but when normalized by their TPM sum they are quite comparable:
|
For those interested in only the assembled sequences, this option can substantially reduce runtime by skipping the Kallisto build transcriptome index step.
7f0b020
to
cfc9d93
Compare
For those interested in only the assembled sequences, this option can
substantially reduce runtime by skipping the Kallisto build
transcriptome index step. Note Kallisto is still used so as to not break
anything downstream, but the index is built from only the
assembled sequences rather than entire transcriptome and
assembled sequences.
For
bracer test
adding--no_transcriptome_quant
decreased theruntime from 311s to 60s (80% decrease) on my machine.