feat: add support for unlinking disks from VM #279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for unlinking a disk from a VM with optional force-removal. This is the first step to fix an issue
in the Proxmox Terraform provider where the disks are not removed correctly if removed from the HCL as part
of a cloud-init based VM.
Testing
I have tested the changes on a local Proxmox install, version
8.0.4
with the following modified example JSON for creating the Qemu VM:qemu1.json
(supply name of iso-file uploaded to Proxmox node):Scenarios
Unlink disk, but don't delete it
Should unlink the disk
virtio1
and leave it asUnused Disk 0
in tabHardware
of VMUnlink disk, and delete it
Should unlink the disk
virtio2
and remove it from tabHardware
of VMUnlink and delete multiple disks
Should unlink the disks
virtio1
andvirtio2
and remove both from tabHardware
of VM