Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix reporter wrong initialization when using config data. #1220

Merged

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Bugfix.

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

fixes #1219

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2020.0.
  • Will pull request to branch of 2022.0.
  • Will pull request to branch of hoxton.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2cd52eb) 76.93% compared to head (7c09779) 76.99%.

Files Patch % Lines
.../configdata/PolarisConfigDataLocationResolver.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             2022.0    #1220      +/-   ##
============================================
+ Coverage     76.93%   76.99%   +0.05%     
- Complexity     1641     1642       +1     
============================================
  Files           260      260              
  Lines          5945     5947       +2     
  Branches        737      738       +1     
============================================
+ Hits           4574     4579       +5     
+ Misses          962      958       -4     
- Partials        409      410       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman merged commit d7fd8e3 into Tencent:2022.0 Jan 15, 2024
5 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 2022/fix-config-data-reporter branch January 17, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spring.cloud.polaris.stat.enabled=false时,Prometheus的httpserver可能存在临时开启的问题
1 participant