Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filterScore and sjdOverhangMin parameters #136

Merged
merged 9 commits into from
Jun 26, 2020
Merged

Add filterScore and sjdOverhangMin parameters #136

merged 9 commits into from
Jun 26, 2020

Conversation

lmurba
Copy link
Contributor

@lmurba lmurba commented Jun 25, 2020

addresses issue here

@lmurba lmurba requested a review from PhilPalmer June 25, 2020 19:30
@lmurba
Copy link
Contributor Author

lmurba commented Jun 25, 2020

@PhilPalmer I'm testing this now, but it looks like it is working. Can you check and make sure I did it correctly? Also can you edit the log section of main.nf? the indentation for filterScore and sjdOverhangMin are off .

Copy link
Contributor

@PhilPalmer PhilPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me!

I've updated the indentation in the log & config. Feel free to merge if you're happy with the testing you've done 🚀

@@ -20,43 +20,87 @@ def helpMessage() {
The typical command for running the pipeline is as follows:
nextflow run main.nf --reads my_reads.csv --gtf genome.gtf --star_index star_dir -profile base,sumner

Input files:
Copy link
Contributor

@PhilPalmer PhilPalmer Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice idea to change the sections of input parameters in the help message & config. I much prefer your new organisation. I think it makes a lot more sense, especially as new input parameters are added for the specific tools eg STAR/trimmomatic etc.

@lmurba lmurba merged commit a5a21a8 into master Jun 26, 2020
@lmurba lmurba deleted the LU_newParams branch June 26, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants