-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix to counts and multiqc files #143
Conversation
@PhilPalmer Can you review this? I addressed this issue as well as this one. Notice that @angarb and I decided not to change any file names for rMATS, only MultiQC and counts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job, this looks perfect to me! Feel free to merge 🚀
variable_read_length = minlen == params.readlength ? false : true | ||
// get run name and date prefix for counts matrix and multiqc | ||
run_name = params.run_name ? params.run_name + "_" : "" | ||
date = new Date().format("MM-dd-yy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice find, this looks ideal, I hadn't heard of new Date()
before
date = new Date().format("MM-dd-yy") | ||
run_prefix = run_name + date | ||
// Set star index to read length unless otherwise specified | ||
star_index = params.star_index ? params.star_index : "/projects/anczukow-lab/reference_genomes/human/Gencode/star_overhangs/star_${params.readlength}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah very cool, you added the selection of the star index based on the read length 👌
@PhilPalmer It looks like this failed the CI test. I didn't think it was failing before. Is this something to worry about? |
No description provided.