Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to counts and multiqc files #143

Merged
merged 19 commits into from
Jun 30, 2020
Merged

Add prefix to counts and multiqc files #143

merged 19 commits into from
Jun 30, 2020

Conversation

lmurba
Copy link
Contributor

@lmurba lmurba commented Jun 29, 2020

No description provided.

@lmurba
Copy link
Contributor Author

lmurba commented Jun 29, 2020

@PhilPalmer Can you review this?

I addressed this issue as well as this one.

Notice that @angarb and I decided not to change any file names for rMATS, only MultiQC and counts.

@lmurba lmurba requested a review from PhilPalmer June 29, 2020 23:05
Copy link
Contributor

@PhilPalmer PhilPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job, this looks perfect to me! Feel free to merge 🚀

variable_read_length = minlen == params.readlength ? false : true
// get run name and date prefix for counts matrix and multiqc
run_name = params.run_name ? params.run_name + "_" : ""
date = new Date().format("MM-dd-yy")
Copy link
Contributor

@PhilPalmer PhilPalmer Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice find, this looks ideal, I hadn't heard of new Date() before

date = new Date().format("MM-dd-yy")
run_prefix = run_name + date
// Set star index to read length unless otherwise specified
star_index = params.star_index ? params.star_index : "/projects/anczukow-lab/reference_genomes/human/Gencode/star_overhangs/star_${params.readlength}"
Copy link
Contributor

@PhilPalmer PhilPalmer Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah very cool, you added the selection of the star index based on the read length 👌

@lmurba
Copy link
Contributor Author

lmurba commented Jun 30, 2020

This pull request addresses two issues: star index (#94) and run prefix(#132).

@lmurba
Copy link
Contributor Author

lmurba commented Jun 30, 2020

@PhilPalmer It looks like this failed the CI test. I didn't think it was failing before. Is this something to worry about?

@PhilPalmer
Copy link
Contributor

Just seen this, I suspect it's fine. I.e. a GitHub issue and not a pipeline issue

If I try and rerun it now it fails but I think that is because the branch has been deleted and it can't checkout to it
image

I really wouldn't worry though because the changes have now been merged and tests are passing on the master branch 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants