remove unused "{added,deleted}_files" columns in the pulls table

alembic/versions/424c7bd5c88c_remove_file_count_columns.py

@@ -0,0 +1,27 @@
+"""
+remove_file_count_columns
+
+Revision ID: 424c7bd5c88c
+Revises: 5de1a9f1e6fa
+Create Date: 2021-04-17 00:52:45.990998
+"""
+
+from alembic import op
+import sqlalchemy as sql
+
+
+# revision identifiers, used by Alembic.
+revision = '424c7bd5c88c'
+down_revision = '5de1a9f1e6fa'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    op.drop_column("pulls", "added_files")
+    op.drop_column("pulls", "deleted_files")
+
+
+def downgrade():
+    op.add_column("pulls", sql.Column("added_files", sql.Integer, nullable=False, default=0))
+    op.add_column("pulls", sql.Column("deleted_files", sql.Integer, nullable=False, default=0))

librarian/storage/models/pull.py

@@ -41,10 +41,6 @@ class Pull(base.Base):
     commits = sql.Column(sql.Integer, nullable=False)
     user_login = sql.Column(sql.String(USER_LOGIN_LEN), nullable=False)
     user_id = sql.Column(sql.Integer, nullable=False)
-
-    # TODO: these fields were designed for a more rich representation and are probably not needed anymore
-    added_files = sql.Column(sql.Integer, nullable=False, default=0)
-    deleted_files = sql.Column(sql.Integer, nullable=False, default=0)
     changed_files = sql.Column(sql.Integer, nullable=False, default=0)
 
     assignees_logins = sql.Column(sql.JSON, default=[])