-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pyarrow version to 16.0.0 #600
Bump pyarrow version to 16.0.0 #600
Conversation
@ihnorton @NikolaosPapailiou although the tests are passing, is there any edge case breakage that may be caused by this update? |
pyproject.toml
Outdated
@@ -13,7 +13,7 @@ dependencies = [ | |||
"importlib-metadata", | |||
"packaging", | |||
"pandas>=1.2.4", | |||
"pyarrow>=3.0.0", | |||
"pyarrow==15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this!
Though I think we may need to update to 16.0.0
instead?
- I see that it is the pyarrow 16.0 release which has
[GH-39532](https://github.com/apache/arrow/issues/39532) - [Python] Compatibility with NumPy 2.0
in it - And on the [Python] Compatibility with NumPy 2.0 issue it lists
16.0
as well:
(Unsure) Also, should it be >=
rather than ==
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't knew that, as both versions are supposedly working with numpy v1.16.1 and above... Will update
About the >= vs ==
, I prefer having pinned dependencies and update them manually if needed, to ensure build stability and environment reproducibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean that users of the package will need to have pyarrow==16.0.0
exactly? What would happen if they depend on another package which, for example, requires pyarrow>=16.1.0
(which seems reasonable for another package to set if they depend on a bug fix from a later release)?
Or am I misunderstanding this and it's a build-time only requirement? And at runtime they can have whatever version they want? (I didn't think so b/c when I looked at this for Vector Search I though you'd use [build-system] requires
to specify build time requirements (like here)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a valid point and I am not sure about that.
I will read about it and update you here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jparismorgan You were right about that, people using tiledb-cloud will need a minimum version of 16.0.0 but it will not block versions higher than that.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Will test with Vector Search once released.
Reverts #600 due to conflicts with numpy v2+
Attempt to resolve the following issue:
Reported by @jparismorgan and related to
pyarrow
version.Related to this Vector Search PR