Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyarrow version to 16.0.0 #600

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Bump pyarrow version to 16.0.0 #600

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8208122
Set pyarrow version to 15.0.0
JohnMoutafis Jul 11, 2024
fffb19a
Set pyarrow version to 16.0.0
JohnMoutafis Jul 11, 2024
ee2e703
Allow for pyarrow versions >= 16.0.0.
JohnMoutafis Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies = [
"importlib-metadata",
"packaging",
"pandas>=1.2.4",
"pyarrow>=3.0.0",
"pyarrow==15.0.0",
Copy link
Contributor

@jparismorgan jparismorgan Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

Though I think we may need to update to 16.0.0 instead?

Screenshot 2024-07-11 at 2 25 38 PM

(Unsure) Also, should it be >= rather than ==?

Copy link
Contributor Author

@JohnMoutafis JohnMoutafis Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't knew that, as both versions are supposedly working with numpy v1.16.1 and above... Will update
About the >= vs ==, I prefer having pinned dependencies and update them manually if needed, to ensure build stability and environment reproducibility

Copy link
Contributor

@jparismorgan jparismorgan Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that users of the package will need to have pyarrow==16.0.0 exactly? What would happen if they depend on another package which, for example, requires pyarrow>=16.1.0 (which seems reasonable for another package to set if they depend on a bug fix from a later release)?

Or am I misunderstanding this and it's a build-time only requirement? And at runtime they can have whatever version they want? (I didn't think so b/c when I looked at this for Vector Search I though you'd use [build-system] requires to specify build time requirements (like here)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid point and I am not sure about that.
I will read about it and update you here!

Copy link
Contributor Author

@JohnMoutafis JohnMoutafis Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jparismorgan You were right about that, people using tiledb-cloud will need a minimum version of 16.0.0 but it will not block versions higher than that.
Nice catch!

"python-dateutil",
"six>=1.10",
# Not directly used on the client, but some server-side environments have
Expand Down
Loading