Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve graph window #335

Merged
merged 40 commits into from
Oct 9, 2024
Merged

Improve graph window #335

merged 40 commits into from
Oct 9, 2024

Conversation

DanicaSTFC
Copy link
Contributor

@DanicaSTFC DanicaSTFC commented Aug 29, 2024

Closes #336 #307 #312 #227 #322 #200 #170

  • Adds pandas
  • Creates classes to generate the tabs in the graphs window. In particular, the following tabs are created: SingleRunResultsWidget, BulkRunResultsWidget, StatisticsResultsWidget.
  • Edits the results reader to be a numpy reader.
  • Edits help text for the graphs.
  • Adds docscrings to GraphsWindow.
  • Improve way labels look, text style in the plots in the graphs window.
  • Adds option in settings to edit the app fontsize to be user defined. Default is 12

The back-end code has been edited, some details are below:

  • Edit argument of "RunResults"
  • Use "data_label" instead of "plot_title"
  • add attribute "self.run_name" in "RunResults"
  • edit "self.title" in "RunResults"
  • edit name of result argument in "SingleRunResultsWidget"
  • use bar plot for relative freq plot.
  • Edit graphs window title.
  • Add file "manipulate_result_file"
  • Edit tab title of single run
  • add superclass
  • Change "Summary" to "Bulk"
  • Use pandas data frame to save data only once when making the plots.
  • use the same methods in the bulk tab. Plotting the right amount of plots.
Single-run plots tab:
  • Edit title to include run name and subvolume points and subvolume size
  • Edit xlabels to include component
  • Add units to xlabels
  • Edit ylabels to be relative frequency, add units %
  • Edit histograms to plot the relative frequency
  • plot statistics on results.
  • remove the for loop for the many tabs and use only one tab whit option to select what parameters to plot.
Bulk tab:
  • Added functionality to pick parameters to plot
  • Rewrote methods to be concise and reusing the single plots methods.
  • removed matplot lib "plt" so it does work better without global variables (using Figure class).
Stat analysis tab:
  • add mean and std in data frame. These will be passed to the classes and not recalculated again.
  • Add new tab with statistical analysis
  • Create class for stat analysis, with widgets.
  • option to plot sub points or size.
  • add option to collapse plots
  • add option to plot all data in stat analysis with mean and std in same plot.
  • edit color scheme

Tests

Installed and tested on a single run and also on a bulk run of points = 1000, 6000 and size = 30, 60, 90

Single tab:
single

Bulk tab:
bulk_1
bulk all

Stat tab:
stat_all
stat_1
stat_1par_all
stat_1par_all_collapsed

Opened new issues:

#340
#339
#338
#357

@DanicaSTFC DanicaSTFC added this to the v24.0.2 milestone Aug 29, 2024
@DanicaSTFC DanicaSTFC self-assigned this Aug 29, 2024
@DanicaSTFC DanicaSTFC linked an issue Sep 12, 2024 that may be closed by this pull request
@DanicaSTFC DanicaSTFC linked an issue Oct 7, 2024 that may be closed by this pull request
4 tasks
src/idvc/idvc.py Outdated Show resolved Hide resolved
@DanicaSTFC DanicaSTFC merged commit 5b3668c into master Oct 9, 2024
3 checks passed
@DanicaSTFC DanicaSTFC deleted the improve-graph-window branch October 9, 2024 11:41
DanicaSTFC added a commit that referenced this pull request Oct 10, 2024
- Reinstates the class SaveObjectWindow as it was before Improve graph window #335
- Creates files graphs_window, save_widgets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment