Bump checkstyle to 10.21.1 and CodeNarc to 3.5.0 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimver
commented
Dec 30, 2024
•
Jimver
commented
- Bump the checkstyle dependency from 8.1 to the latest version 10.21.1
- This is needed in particular for Java 21 support, see releasenotes: https://checkstyle.sourceforge.io/releasenotes.html#Release_10.18.0
- We need to bump to JDK 11 since the new version of checkstyle requires it: upgrade minimal required jdk version to 11 checkstyle/checkstyle#9146.
- Migrate checkstyle xml to remove deprecated properties and add new modules, see:
- JavadocMethodCheck: remove deprecated properties ignoreMethodNamesRegex, minLineCount, allowMissingJavadoc, allowMissingPropertyJavadoc checkstyle/checkstyle#7096
- new check: MissingJavadocMethod from JavadocMethod checkstyle/checkstyle#6703
- Made TestFile.java public to trigger the missing javadoc warnings.
- Bump CodeNarc from 1.4 to 3.5.0 due to class loading issues on JDK 11.
- This means we also need to bump groovy to 3.0.9.
- Bump the checkstyle dependency from 8.1 to the latest version 10.21.1 - This is needed in particular for Java 21 support, see releasenotes: https://checkstyle.sourceforge.io/releasenotes.html#Release_10.18.0 - We need to bump to JDK 11 since the new version of checkstyle requires it: checkstyle/checkstyle#9146. - Migrate checkstyle xml to remove deprecated properties and add new modules, see: - checkstyle/checkstyle#7096 - checkstyle/checkstyle#6703 - Made TestFile.java public to trigger the missing javadoc warnings. - Bump CodeNarc from 1.4 to 3.5.0 due to class loading issues on JDK 11. - This means we also need to bump groovy to 3.0.9.
Jimver
force-pushed
the
checkstyle-bump
branch
from
db7196d to
fa795cf
Compare
|
This PR depends on #259, as checkstyle also uses saxon |
|
Fixes #262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.